diff options
| author |  ulfjack <ulfjack@google.com> | 2018-06-07 00:42:22 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-06-07 00:43:39 -0700 |
| commit | ef77f872d4bc1325c2405d6f260c3e98f22d895e (patch) | |
| tree | 30f678efc98d81ebf3cf6e218172859240ed5c3b /src/test/shell/integration | |
| parent | 602cc856051b02328ed56e2af808b829dafecd4b (diff) | |
Rewrite TargetPattern failure reporting
Report failures in TargetPatternFunction, rather than in its callers. Since we
can't distinguish between keep_going and nokeep_going modes, we otherwise end
up double-reporting errors. In the particular case that's covered by the
build_event_stream_test.sh, we end up reporting the same target pattern as both
skipped and failed.
Unfortunately, this means we cannot report whether the target pattern was
skipped or failed, so the pattern_skipped event is now unused (if we agree that
this is acceptable, I'll remove the corresponding infrastructure).
PiperOrigin-RevId: 199593700
Diffstat (limited to 'src/test/shell/integration')
| -rwxr-xr-x | src/test/shell/integration/build_event_stream_test.sh | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/test/shell/integration/build_event_stream_test.sh b/src/test/shell/integration/build_event_stream_test.sh index 5a8263d1f1..0c6b0e7a6d 100755 --- a/src/test/shell/integration/build_event_stream_test.sh +++ b/src/test/shell/integration/build_event_stream_test.sh @@ -673,7 +673,6 @@ function test_loading_failure() { # reason for the target expansion event not resulting in targets # being expanded. (bazel build --build_event_text_file=$TEST_log \ - --noexperimental_skyframe_target_pattern_evaluator \ //does/not/exist && fail "build failure expected") || true expect_log_once 'aborted' expect_log_once 'reason: LOADING_FAILURE' |