aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/test/shell/integration/progress_reporting_test.sh
diff options
context:
space:
mode:
authorGravatar Androbin <robin.richtsfeld@gmail.com>2017-12-14 07:24:27 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2017-12-14 07:25:56 -0800
commitef381e54b124a7bb71dcb883fdc999f3bd37d4ed (patch)
tree47f8f0e98ccfb24460b7b1d389670838eb08620b /src/test/shell/integration/progress_reporting_test.sh
parent1b66574799a242b09f88a1b0cfe47a956f17fa87 (diff)
Shell code cleanup
- Argument mixes string and array. Use * or separate argument. - Quote the grep pattern so the shell won't interpret it. - Use "${var:?}" to ensure this never expands to /* . - > is for string comparisons. Use -gt instead. - Quote the parameter to -name so the shell won't interpret it. Closes #4163. PiperOrigin-RevId: 179042046
Diffstat (limited to 'src/test/shell/integration/progress_reporting_test.sh')
-rwxr-xr-xsrc/test/shell/integration/progress_reporting_test.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test/shell/integration/progress_reporting_test.sh b/src/test/shell/integration/progress_reporting_test.sh
index f01199423f..7d9ea60a4c 100755
--- a/src/test/shell/integration/progress_reporting_test.sh
+++ b/src/test/shell/integration/progress_reporting_test.sh
@@ -54,7 +54,7 @@ function wait_for_command() {
kill -9 "$pid"
# A fail() here would not end the script if we are in a subshell, so the
# caller must check the return value.
- echo "Command $@ did not die within $wait_time seconds"
+ echo "Command $* did not die within $wait_time seconds"
return 1
}