diff options
| author |  brandjon <brandjon@google.com> | 2017-04-29 16:03:32 +0200 |
|---|---|---|
| committer |  Vladimir Moskva <vladmos@google.com> | 2017-04-30 23:14:25 +0200 |
| commit | b712f335a945c81a6b77fd48e96103ff09c8967b (patch) | |
| tree | b8ac0e5aa200cf19717aa22e51cb9abc457be572 /src/test/shell/integration/BUILD | |
| parent | e7fe50aa727df9ef0a3d37fa258d017971035515 (diff) | |
Make Skylark interpreter read Skylark command-line flags
This is the second of two CLs for making command line options able to affect the Skylark interpreter. For the main kinds of evaluation contexts -- package loading, .bzl loading, rule analysis, aspect analysis, and computed defaults -- the SkylarkSemanticsOptions object is retrieved from Skyframe and passed along to the Environment builder. For other contexts such as tests, default values of builtin functions, and standalone Skylark, flags are currently not processed.
In the future, we may want to split into separate files the options that affect "pure" Skylark vs the options that affect Bazel-flavored Skylark. One possibility is to subclass SkylarkSemanticsOptions into SkylarkBazelSemanticsOptions, and go through an indirection in SkylarkUtils.
We could also pass SkylarkSemanticsOptions to the parser, to support --incompatible_* changes that alter Skylark's syntax. I don't think that's needed at the moment.
RELNOTES: None
PiperOrigin-RevId: 154628391
Diffstat (limited to 'src/test/shell/integration/BUILD')
| -rw-r--r-- | src/test/shell/integration/BUILD | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/src/test/shell/integration/BUILD b/src/test/shell/integration/BUILD index ad448df623..cdce926014 100644 --- a/src/test/shell/integration/BUILD +++ b/src/test/shell/integration/BUILD @@ -181,6 +181,13 @@ sh_test( ) sh_test( + name = "skylark_flag_test", + size = "small", + srcs = ["skylark_flag_test.sh"], + data = [":test-deps"], +) + +sh_test( name = "ui_test", size = "medium", srcs = ["ui_test.sh"], |