diff options
| author |  Laszlo Csomor <laszlocsomor@google.com> | 2018-03-20 08:26:06 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-03-20 08:27:22 -0700 |
| commit | b1be5816ec1bf8e1172c1bed4f29b4e6c6bb7202 (patch) | |
| tree | b537fbaa7d503e3a58c93e59ee9ddd76a82685ec /src/test/py | |
| parent | f87a656610413ffbc4ef44cb89081c9a111b4827 (diff) | |
runfiles,Python: remove library from @bazel_tools
Temporarily remove the Python runfiles library
from @bazel_tools and so prevent releasing it in
Bazel 0.12.0.
Motivation: https://github.com/bazelbuild/bazel/issues/4878
Fixing that bug *after* the python library is in
release Bazel would be harder because users would
need to update their code and BUILD files.
Fixing that bug before the library is released is
a lot easier because nobody depends on it yet, and
we can release the library when it's in the right
place.
Closes #4879.
Change-Id: I8adc219410571f9e2a4c8060f5b3239b957fbd5f
PiperOrigin-RevId: 189744985
Diffstat (limited to 'src/test/py')
| -rw-r--r-- | src/test/py/bazel/runfiles_test.py | 18 |
1 files changed, 12 insertions, 6 deletions
diff --git a/src/test/py/bazel/runfiles_test.py b/src/test/py/bazel/runfiles_test.py index bea4979db0..1a9a6703b2 100644 --- a/src/test/py/bazel/runfiles_test.py +++ b/src/test/py/bazel/runfiles_test.py @@ -131,15 +131,19 @@ class RunfilesTest(test_base.TestBase): i += 2 - def testPythonRunfilesLibraryInBazelToolsRepo(self): - self._AssertPythonRunfilesLibraryInBazelToolsRepo("py", "Python") + # TODO(laszlocsomor): re-enable after + # https://github.com/bazelbuild/bazel/issues/4878 is fixed. + # def testPythonRunfilesLibraryInBazelToolsRepo(self): + # self._AssertPythonRunfilesLibraryInBazelToolsRepo("py", "Python") def testRunfilesLibrariesFindRunfilesWithoutEnvvars(self): for s, t in [ ("WORKSPACE.mock", "WORKSPACE"), ("bar/BUILD.mock", "bar/BUILD"), - ("bar/bar.py", "bar/bar.py"), - ("bar/bar-py-data.txt", "bar/bar-py-data.txt"), + # TODO(laszlocsomor): uncomment Python files after + # https://github.com/bazelbuild/bazel/issues/4878 is fixed. + # ("bar/bar.py", "bar/bar.py"), + # ("bar/bar-py-data.txt", "bar/bar-py-data.txt"), ("bar/Bar.java", "bar/Bar.java"), ("bar/bar-java-data.txt", "bar/bar-java-data.txt"), ]: @@ -151,10 +155,12 @@ class RunfilesTest(test_base.TestBase): self.AssertExitCode(exit_code, 0, stderr) bazel_bin = stdout[0] - exit_code, _, stderr = self.RunBazel(["build", "//bar:all"]) + exit_code, _, stderr = self.RunBazel(["build", "//bar:bar-java"]) self.AssertExitCode(exit_code, 0, stderr) - for lang in [("py", "Python", "bar.py"), ("java", "Java", "Bar.java")]: + # TODO(laszlocsomor): add Python after + # https://github.com/bazelbuild/bazel/issues/4878 is fixed. + for lang in [("java", "Java", "Bar.java")]: if test_base.TestBase.IsWindows(): bin_path = os.path.join(bazel_bin, "bar/bar-%s.exe" % lang[0]) else: |