Clean up string representations for attr and attr.*

This change is a part of global string representations cleanup using the
--incompatible_descriptive_string_representations flag, however the change to
attr and attr.* is not affected by the flag because string representations of
these objects used to contain nondeterministic information (memory addresses).

PiperOrigin-RevId: 161192934

1 files changed, 20 insertions, 1 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkStringRepresentationsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkStringRepresentationsTest.java
index ea68ddc9f6..82e2c1e1c1 100644
--- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkStringRepresentationsTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkStringRepresentationsTest.java
@@ -214,7 +214,6 @@ public class SkylarkStringRepresentationsTest extends SkylarkTestCase {
     assertStringRepresentation("struct(d = 4, c = 3)", "struct(c = 3, d = 4)");
   }
 
-
   @Test
   public void testStringRepresentations_Functions() throws Exception {
     setSkylarkSemanticsOptions("--incompatible_descriptive_string_representations=true");
@@ -248,6 +247,26 @@ public class SkylarkStringRepresentationsTest extends SkylarkTestCase {
   }
 
   @Test
+  public void testStringRepresentations_Attr() throws Exception {
+    setSkylarkSemanticsOptions("--incompatible_descriptive_string_representations=true");
+
+    assertStringRepresentation("attr", "<attr>");
+    assertStringRepresentation("attr.int()", "<attr.int>");
+    assertStringRepresentation("attr.string()", "<attr.string>");
+    assertStringRepresentation("attr.label()", "<attr.label>");
+    assertStringRepresentation("attr.string_list()", "<attr.string_list>");
+    assertStringRepresentation("attr.int_list()", "<attr.int_list>");
+    assertStringRepresentation("attr.label_list()", "<attr.label_list>");
+    assertStringRepresentation("attr.label_keyed_string_dict()", "<attr.label_keyed_string_dict>");
+    assertStringRepresentation("attr.bool()", "<attr.bool>");
+    assertStringRepresentation("attr.output()", "<attr.output>");
+    assertStringRepresentation("attr.output_list()", "<attr.output_list>");
+    assertStringRepresentation("attr.string_dict()", "<attr.string_dict>");
+    assertStringRepresentation("attr.string_list_dict()", "<attr.string_list_dict>");
+    assertStringRepresentation("attr.license()", "<attr.license>");
+  }
+
+  @Test
   public void testLegacyStringRepresentations_Labels() throws Exception {
     setSkylarkSemanticsOptions("--incompatible_descriptive_string_representations=false");