diff options
author | 2018-06-21 10:13:53 -0700 | |
---|---|---|
committer | 2018-06-21 10:15:17 -0700 | |
commit | dcd0abc97b8372949b592aae817e5ad12f040ab4 (patch) | |
tree | 0e56c9677a0044795a0c4d5d4b92838a67db2032 /src/test/java | |
parent | 5728af65e8b89b9dd3a5ac2b717c93ec5333ca18 (diff) |
Migrate DefaultInfo and its provider to skylarkbuildapi
RELNOTES: None.
PiperOrigin-RevId: 201544076
Diffstat (limited to 'src/test/java')
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/skylark/SkylarkIntegrationTest.java | 22 | ||||
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java | 3 |
2 files changed, 23 insertions, 2 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkIntegrationTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkIntegrationTest.java index 877b1a3f24..234899fbf0 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkIntegrationTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkIntegrationTest.java @@ -576,7 +576,7 @@ public class SkylarkIntegrationTest extends BuildViewTestCase { } @Test - public void testCannotSpecifyRunfilesWithDataOrDefaultRunfiles() throws Exception { + public void testCannotSpecifyRunfilesWithDataOrDefaultRunfiles_struct() throws Exception { scratch.file( "test/skylark/extension.bzl", "def custom_rule_impl(ctx):", @@ -596,6 +596,26 @@ public class SkylarkIntegrationTest extends BuildViewTestCase { } @Test + public void testCannotSpecifyRunfilesWithDataOrDefaultRunfiles_defaultInfo() throws Exception { + scratch.file( + "test/skylark/extension.bzl", + "def custom_rule_impl(ctx):", + " rf = ctx.runfiles()", + " return struct(DefaultInfo(runfiles = rf, default_runfiles = rf))", + "", + "custom_rule = rule(implementation = custom_rule_impl)"); + + checkError( + "test/skylark", + "cr", + "Cannot specify the provider 'runfiles' together with " + + "'data_runfiles' or 'default_runfiles'", + "load('//test/skylark:extension.bzl', 'custom_rule')", + "", + "custom_rule(name = 'cr')"); + } + + @Test public void testInstrumentedFilesProviderWithCodeCoverageDiabled() throws Exception { scratch.file( "test/skylark/extension.bzl", diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java index 0312144c85..1de6ab0899 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java @@ -1289,7 +1289,8 @@ public class SkylarkRuleImplementationFunctionsTest extends SkylarkTestCase { getConfiguredTarget("//test:my_rule"); fail(); } catch (AssertionError expected) { - assertThat(expected).hasMessageThat().contains("Invalid field for default provider: foo"); + assertThat(expected).hasMessageThat() + .contains("unexpected keyword 'foo' in call to DefaultInfo"); } } |