diff options
author | vladmos <vladmos@google.com> | 2017-07-14 19:04:55 +0200 |
---|---|---|
committer | Jakob Buchgraber <buchgr@google.com> | 2017-07-17 10:10:50 +0200 |
commit | d4cc4b6fec1d4a6c2f478628a8a985bcf6502253 (patch) | |
tree | 22ec085e58d16cec0119eee919fdc9ff2ef3c965 /src/test/java | |
parent | 9f18a511205fbd74e188f0d42974fe329b9cffe6 (diff) |
Clean up string representations for unknown objects
Don't call the `toString` method on unknown objects as it potentially
breaks hermeticity and determinism. Use a generic string like
"<unknown object package.ClassName>" instead.
PiperOrigin-RevId: 161970449
Diffstat (limited to 'src/test/java')
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/skylark/SkylarkStringRepresentationsTest.java | 11 | ||||
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/syntax/EvaluationTest.java | 19 |
2 files changed, 17 insertions, 13 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkStringRepresentationsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkStringRepresentationsTest.java index 82e2dfed90..8db33169eb 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkStringRepresentationsTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkStringRepresentationsTest.java @@ -389,6 +389,17 @@ public class SkylarkStringRepresentationsTest extends SkylarkTestCase { } @Test + public void testStringRepresentationsOfUnknownObjects() throws Exception { + update("mock", new Object()); + + assertThat(eval("str(mock)")).isEqualTo("<unknown object java.lang.Object>"); + assertThat(eval("repr(mock)")).isEqualTo("<unknown object java.lang.Object>"); + assertThat(eval("'{}'.format(mock)")).isEqualTo("<unknown object java.lang.Object>"); + assertThat(eval("'%s' % mock")).isEqualTo("<unknown object java.lang.Object>"); + assertThat(eval("'%r' % mock")).isEqualTo("<unknown object java.lang.Object>"); + } + + @Test public void testLegacyStringRepresentations_Labels() throws Exception { setSkylarkSemanticsOptions("--incompatible_descriptive_string_representations=false"); diff --git a/src/test/java/com/google/devtools/build/lib/syntax/EvaluationTest.java b/src/test/java/com/google/devtools/build/lib/syntax/EvaluationTest.java index 53fdcaae23..057af394dd 100644 --- a/src/test/java/com/google/devtools/build/lib/syntax/EvaluationTest.java +++ b/src/test/java/com/google/devtools/build/lib/syntax/EvaluationTest.java @@ -618,15 +618,6 @@ public class EvaluationTest extends EvaluationTestCase { }; } - private Object createUnknownObj() { - return new Object() { - @Override - public String toString() { - return "<unknown object>"; - } - }; - } - @Test public void testPercOnObject() throws Exception { newTest("--incompatible_descriptive_string_representations=true") @@ -636,8 +627,8 @@ public class EvaluationTest extends EvaluationTestCase { .update("obj", createObjWithStr()) .testStatement("'%s' % obj", "<str legacy marker>"); newTest() - .update("unknown", createUnknownObj()) - .testStatement("'%s' % unknown", "<unknown object>"); + .update("unknown", new Object()) + .testStatement("'%s' % unknown", "<unknown object java.lang.Object>"); } @Test @@ -649,8 +640,10 @@ public class EvaluationTest extends EvaluationTestCase { .update("obj", createObjWithStr()) .testStatement("'%s %s' % (obj, obj)", "<str legacy marker> <str legacy marker>"); newTest() - .update("unknown", createUnknownObj()) - .testStatement("'%s %s' % (unknown, unknown)", "<unknown object> <unknown object>"); + .update("unknown", new Object()) + .testStatement( + "'%s %s' % (unknown, unknown)", + "<unknown object java.lang.Object> <unknown object java.lang.Object>"); } @Test |