aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/test/java
diff options
context:
space:
mode:
authorGravatar lpino <lpino@google.com>2018-02-05 09:39:32 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2018-02-05 09:41:16 -0800
commit6d032941384ec7b7baf040e47680712e26fa3857 (patch)
tree34094a79b39cc6a0ed54c7d49d1fbf247abcdd33 /src/test/java
parent73fcc7a72d70245280f63d171c654babf1cc579a (diff)
Simplify RuleClassProviders by making most RuleSets have their own class.
PiperOrigin-RevId: 184540561
Diffstat (limited to 'src/test/java')
-rw-r--r--src/test/java/com/google/devtools/build/lib/bazel/rules/BazelRuleClassProviderTest.java8
-rw-r--r--src/test/java/com/google/devtools/build/lib/rules/cpp/BUILD1
-rw-r--r--src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonTest.java9
3 files changed, 11 insertions, 7 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/bazel/rules/BazelRuleClassProviderTest.java b/src/test/java/com/google/devtools/build/lib/bazel/rules/BazelRuleClassProviderTest.java
index ba69b6d721..502a048cbb 100644
--- a/src/test/java/com/google/devtools/build/lib/bazel/rules/BazelRuleClassProviderTest.java
+++ b/src/test/java/com/google/devtools/build/lib/bazel/rules/BazelRuleClassProviderTest.java
@@ -96,7 +96,7 @@ public class BazelRuleClassProviderTest {
@Test
public void genericConsistency() {
- checkModule(BazelRuleClassProvider.GENERIC_RULES);
+ checkModule(GenericRules.INSTANCE);
}
@Test
@@ -116,12 +116,12 @@ public class BazelRuleClassProviderTest {
@Test
public void cppConsistency() {
- checkModule(BazelRuleClassProvider.CPP_RULES);
+ checkModule(CcRules.INSTANCE);
}
@Test
public void javaConsistency() {
- checkModule(BazelRuleClassProvider.JAVA_RULES);
+ checkModule(JavaRules.INSTANCE);
}
@Test
@@ -136,7 +136,7 @@ public class BazelRuleClassProviderTest {
@Test
public void objcConsistency() {
- checkModule(BazelRuleClassProvider.OBJC_RULES);
+ checkModule(ObjcRules.INSTANCE);
}
@Test
diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/BUILD b/src/test/java/com/google/devtools/build/lib/rules/cpp/BUILD
index 3aeeecd08a..73fb388424 100644
--- a/src/test/java/com/google/devtools/build/lib/rules/cpp/BUILD
+++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/BUILD
@@ -30,6 +30,7 @@ java_test(
"//src/main/java/com/google/devtools/build/lib/collect/nestedset",
"//src/main/java/com/google/devtools/build/lib/concurrent",
"//src/main/java/com/google/devtools/build/lib/rules/cpp",
+ "//src/main/java/com/google/devtools/build/lib/rules/platform",
"//src/main/java/com/google/devtools/build/lib/skyframe/serialization/testutils",
"//src/main/java/com/google/devtools/build/lib/vfs",
"//src/main/java/com/google/devtools/build/lib/vfs/inmemoryfs",
diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonTest.java
index 68edd89798..644761235e 100644
--- a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonTest.java
+++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonTest.java
@@ -33,12 +33,15 @@ import com.google.devtools.build.lib.analysis.mock.BazelAnalysisMock;
import com.google.devtools.build.lib.analysis.util.AnalysisMock;
import com.google.devtools.build.lib.analysis.util.BuildViewTestCase;
import com.google.devtools.build.lib.bazel.rules.BazelRuleClassProvider;
+import com.google.devtools.build.lib.bazel.rules.CcRules;
+import com.google.devtools.build.lib.bazel.rules.GenericRules;
import com.google.devtools.build.lib.cmdline.Label;
import com.google.devtools.build.lib.cmdline.PackageIdentifier;
import com.google.devtools.build.lib.cmdline.RepositoryName;
import com.google.devtools.build.lib.rules.ToolchainType;
import com.google.devtools.build.lib.rules.core.CoreRules;
import com.google.devtools.build.lib.rules.cpp.transitions.LipoDataTransitionRuleSet;
+import com.google.devtools.build.lib.rules.platform.PlatformRules;
import com.google.devtools.build.lib.rules.repository.CoreWorkspaceRules;
import com.google.devtools.build.lib.util.FileType;
import com.google.devtools.build.lib.util.OsUtils;
@@ -973,9 +976,9 @@ public class CcCommonTest extends BuildViewTestCase {
BazelRuleClassProvider.BAZEL_SETUP.init(builder);
CoreRules.INSTANCE.init(builder);
CoreWorkspaceRules.INSTANCE.init(builder);
- BazelRuleClassProvider.PLATFORM_RULES.init(builder);
- BazelRuleClassProvider.GENERIC_RULES.init(builder);
- BazelRuleClassProvider.CPP_RULES.init(builder);
+ PlatformRules.INSTANCE.init(builder);
+ GenericRules.INSTANCE.init(builder);
+ CcRules.INSTANCE.init(builder);
return builder.build();
}