diff options
| author |  juliexxia <juliexxia@google.com> | 2017-09-21 20:56:52 +0200 |
|---|---|---|
| committer |  Damien Martin-Guillerez <dmarting@google.com> | 2017-09-22 12:15:37 +0200 |
| commit | 5e2b0da425f9f8488685f1f01f5f223996879c85 (patch) | |
| tree | 3d9d7a847d357b2b9d11994dd6c5e80b58b32c79 /src/test/java | |
| parent | 60f35034f5a2bbaee629695782beb4a3c0216f0f (diff) | |
Add more thorough error reporting behavior for when config_setting has multiple constraint_values from the same constraint_setting (re: #350)
PiperOrigin-RevId: 169577576
Diffstat (limited to 'src/test/java')
| -rw-r--r-- | src/test/java/com/google/devtools/build/lib/rules/config/ConfigSettingTest.java | 26 |
1 files changed, 20 insertions, 6 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/rules/config/ConfigSettingTest.java b/src/test/java/com/google/devtools/build/lib/rules/config/ConfigSettingTest.java index f45a85edca..4bc2d49503 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/config/ConfigSettingTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/config/ConfigSettingTest.java @@ -1237,17 +1237,31 @@ public class ConfigSettingTest extends BuildViewTestCase { */ @Test public void multipleValuesPerSetting() throws Exception { - checkError("foo", "bad", - "in :target_platforms attribute of config_setting rule //foo:bad: " - + "error while parsing configuration settings: " - + "the target platform contains multiple values '//foo:space_needle' " - + "and '//foo:empire_state' that map to the same setting '//foo:notable_building'", + checkError( + "foo", + "bad", + "in config_setting rule //foo:bad: " + + "Duplicate constraint_values detected: " + + "constraint_setting //foo:notable_building has " + + "[//foo:empire_state, //foo:space_needle], " + + "constraint_setting //foo:museum has " + + "[//foo:moma, //foo:sam]", "constraint_setting(name = 'notable_building')", "constraint_value(name = 'empire_state', constraint_setting = 'notable_building')", "constraint_value(name = 'space_needle', constraint_setting = 'notable_building')", + "constraint_value(name = 'peace_arch', constraint_setting = 'notable_building')", + "constraint_setting(name = 'museum')", + "constraint_value(name = 'moma', constraint_setting = 'museum')", + "constraint_value(name = 'sam', constraint_setting = 'museum')", "config_setting(", " name = 'bad',", - " constraint_values = [':empire_state', ':space_needle'],", + " constraint_values = [", + " ':empire_state',", + " ':space_needle',", + " ':moma',", + " ':sam',", + " ],", ");"); } } + |