diff options
| author |  cparsons <cparsons@google.com> | 2018-05-22 14:00:22 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-05-22 14:01:24 -0700 |
| commit | 28cc833b50d55051ac087a5362b8c14cb67893e8 (patch) | |
| tree | 5dc6629d2b4d629723e90195a5c7d50ada252597 /src/test/java | |
| parent | 055d6c619ab572debddb3518616c75f64462c145 (diff) | |
Migrate JavaInfo's provider to use the new provider pattern.
This dramatically improves documentation generation for JavaInfo and it makes it far more maintainable and extensible going forward.
RELNOTES: None.
PiperOrigin-RevId: 197619040
Diffstat (limited to 'src/test/java')
| -rw-r--r-- | src/test/java/com/google/devtools/build/docgen/SkylarkDocumentationTest.java | 13 |
1 files changed, 5 insertions, 8 deletions
diff --git a/src/test/java/com/google/devtools/build/docgen/SkylarkDocumentationTest.java b/src/test/java/com/google/devtools/build/docgen/SkylarkDocumentationTest.java index b4a44e1ecf..15f08d521a 100644 --- a/src/test/java/com/google/devtools/build/docgen/SkylarkDocumentationTest.java +++ b/src/test/java/com/google/devtools/build/docgen/SkylarkDocumentationTest.java @@ -16,7 +16,6 @@ package com.google.devtools.build.docgen; import static com.google.common.truth.Truth.assertThat; import static com.google.common.truth.Truth.assertWithMessage; -import com.google.common.base.Function; import com.google.common.collect.ImmutableList; import com.google.common.collect.Iterables; import com.google.devtools.build.docgen.skylark.SkylarkBuiltinMethodDoc; @@ -436,13 +435,11 @@ public class SkylarkDocumentationTest extends SkylarkTestCase { + "MockClassWithContainerReturnValues.skylark()"); } - private Iterable<Method> extractMethods(Collection<SkylarkJavaMethodDoc> methods) { - return Iterables.transform(methods, new Function<SkylarkJavaMethodDoc, Method>() { - @Override - public Method apply(SkylarkJavaMethodDoc input) { - return input.getMethod(); - } - }); + private Iterable<Method> extractMethods(Collection<SkylarkMethodDoc> methods) { + return methods.stream() + .filter(methodDoc -> methodDoc instanceof SkylarkJavaMethodDoc) + .map(methodDoc -> ((SkylarkJavaMethodDoc) methodDoc).getMethod()) + .collect(Collectors.toList()); } private Map<String, SkylarkModuleDoc> collect(Class<?> classObject) { |