diff options
| author |  jcater <jcater@google.com> | 2017-10-13 17:23:44 +0200 |
|---|---|---|
| committer |  Jakob Buchgraber <buchgr@google.com> | 2017-10-16 17:48:21 +0200 |
| commit | 25fb5b1bfb44412df3753f1213027b8fe919d892 (patch) | |
| tree | 72291ce3d0a2d98dce902fb6e94423476f468dbb /src/test/java | |
| parent | a56ccbfb4215b1589c6f81004a5249d32073bafb (diff) | |
Apply suggested fixes that were missed in http://https://github.com/bazelbuild/bazel/commit/5b4b7a3ebb83a8c93d8f68ade7bf1242c8590256
PiperOrigin-RevId: 172099288
Diffstat (limited to 'src/test/java')
| -rw-r--r-- | src/test/java/com/google/devtools/build/lib/skyframe/PackageLookupFunctionTest.java | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/skyframe/PackageLookupFunctionTest.java b/src/test/java/com/google/devtools/build/lib/skyframe/PackageLookupFunctionTest.java index 9d3d23b5b0..e24dca8c96 100644 --- a/src/test/java/com/google/devtools/build/lib/skyframe/PackageLookupFunctionTest.java +++ b/src/test/java/com/google/devtools/build/lib/skyframe/PackageLookupFunctionTest.java @@ -444,17 +444,15 @@ public abstract class PackageLookupFunctionTest extends FoundationTestCase { return params; } - private String description; - private String repositoryPath; - private String packagePath; - private String expectedCorrectedPackageIdentifier; + private final String repositoryPath; + private final String packagePath; + private final String expectedCorrectedPackageIdentifier; public CorrectedLocalRepositoryTest( - String description, + String unusedDescription, String repositoryPath, String packagePath, String expectedCorrectedPackageIdentifier) { - this.description = description; this.repositoryPath = repositoryPath; this.packagePath = packagePath; this.expectedCorrectedPackageIdentifier = expectedCorrectedPackageIdentifier; @@ -467,7 +465,6 @@ public abstract class PackageLookupFunctionTest extends FoundationTestCase { @Test public void testCorrectPackageDetection_relativePath() throws Exception { - String fullPackagePath = packagePath + "/BUILD"; scratch.overwriteFile( "WORKSPACE", "local_repository(name='local', path='" + repositoryPath + "')"); scratch.file(PathFragment.create(repositoryPath).getRelative("WORKSPACE").getPathString()); @@ -495,7 +492,6 @@ public abstract class PackageLookupFunctionTest extends FoundationTestCase { @Test public void testCorrectPackageDetection_absolutePath() throws Exception { - String fullPackagePath = packagePath + "/BUILD"; scratch.overwriteFile( "WORKSPACE", "local_repository(name='local', path=__workspace_dir__ + '/" + repositoryPath + "')"); |