Add unit tests for AndroidStudioInfoAspect and implement dependency collection.

--
MOS_MIGRATED_REVID=102976551

2 files changed, 318 insertions, 3 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java
index 02e1f8b2ce..754500c48c 100644
--- a/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java
+++ b/src/test/java/com/google/devtools/build/lib/analysis/util/BuildViewTestCase.java
@@ -739,8 +739,8 @@ public abstract class BuildViewTestCase extends FoundationTestCase {
     eventCollector.clear();
     ConfiguredTarget target = scratchConfiguredTarget(packageName, ruleName,
                                                      lines);
-    assertFalse("Rule '" + "//" + packageName + ":" + ruleName
-        + "' did contain an error",
+    assertFalse(
+        "Rule '" + "//" + packageName + ":" + ruleName + "' did contain an error",
         view.hasErrors(target));
     return assertContainsEvent(expectedWarningMessage);
   }
@@ -1273,6 +1273,18 @@ public abstract class BuildViewTestCase extends FoundationTestCase {
       int loadingPhaseThreads,
       boolean doAnalysis,
       EventBus eventBus) throws Exception {
+    return update(
+        targets, ImmutableList.<String>of(), keepGoing, loadingPhaseThreads, doAnalysis, eventBus);
+  }
+
+  protected AnalysisResult update(
+      List<String> targets,
+      List<String> aspects,
+      boolean keepGoing,
+      int loadingPhaseThreads,
+      boolean doAnalysis,
+      EventBus eventBus)
+      throws Exception {
 
     LoadingPhaseRunner.Options loadingOptions =
         Options.getDefaults(LoadingPhaseRunner.Options.class);
@@ -1293,7 +1305,7 @@ public abstract class BuildViewTestCase extends FoundationTestCase {
     return view.update(
         loadingResult,
         masterConfig,
-        ImmutableList.<String>of(),
+        aspects,
         viewOptions,
         AnalysisTestUtil.TOP_LEVEL_ARTIFACT_CONTEXT,
         reporter,
diff --git a/src/test/java/com/google/devtools/build/lib/ideinfo/AndroidStudioInfoAspectTest.java b/src/test/java/com/google/devtools/build/lib/ideinfo/AndroidStudioInfoAspectTest.java
new file mode 100644
index 0000000000..3268bf7668
--- /dev/null
+++ b/src/test/java/com/google/devtools/build/lib/ideinfo/AndroidStudioInfoAspectTest.java
@@ -0,0 +1,303 @@
+// Copyright 2014 Google Inc. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package com.google.devtools.build.lib.ideinfo;
+
+import static com.google.common.collect.Iterables.transform;
+import static com.google.common.truth.Truth.assertThat;
+
+import com.google.common.base.Function;
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableMap;
+import com.google.common.eventbus.EventBus;
+import com.google.devtools.build.lib.actions.Artifact;
+import com.google.devtools.build.lib.analysis.BuildView.AnalysisResult;
+import com.google.devtools.build.lib.analysis.actions.BinaryFileWriteAction;
+import com.google.devtools.build.lib.analysis.util.BuildViewTestCase;
+import com.google.devtools.build.lib.ideinfo.androidstudio.AndroidStudioIdeInfo.ArtifactLocation;
+import com.google.devtools.build.lib.ideinfo.androidstudio.AndroidStudioIdeInfo.RuleIdeInfo;
+import com.google.devtools.build.lib.skyframe.AspectValue;
+
+import java.util.Collection;
+import java.util.Map;
+
+import javax.annotation.Nullable;
+
+/**
+ * Tests for {@link AndroidStudioInfoAspect} validating proto's contents.
+ */
+public class AndroidStudioInfoAspectTest extends BuildViewTestCase {
+
+  public static final Function<ArtifactLocation, String> ARTIFACT_TO_RELATIVE_PATH =
+      new Function<ArtifactLocation, String>() {
+        @Nullable
+        @Override
+        public String apply(ArtifactLocation artifactLocation) {
+          return artifactLocation.getRelativePath();
+        }
+      };
+
+  public void testSimpleJavaLibrary() throws Exception {
+    scratch.file(
+        "com/google/example/BUILD",
+        "java_library(",
+        "    name = \"simple\",",
+        "    srcs = [\"simple/Simple.java\"]",
+        ")",
+        "java_library(",
+        "    name = \"complex\",",
+        "    srcs = [\"complex/Complex.java\"],",
+        "    deps = [\":simple\"]",
+        ")");
+    String target = "//com/google/example:simple";
+    Map<String, RuleIdeInfo> ruleIdeInfos = buildRuleIdeInfo(target);
+    assertThat(ruleIdeInfos.size()).isEqualTo(1);
+    RuleIdeInfo ruleIdeInfo = getRuleInfoAndVerifyLabel(target, ruleIdeInfos);
+    assertThat(ruleIdeInfo.getDependenciesCount()).isEqualTo(0);
+    assertThat(relativePathsForSourcesOf(ruleIdeInfo))
+        .containsExactly("com/google/example/simple/Simple.java");
+  }
+
+  private static Iterable<String> relativePathsForSourcesOf(RuleIdeInfo ruleIdeInfo) {
+    return transform(ruleIdeInfo.getJavaRuleIdeInfo().getSourcesList(), ARTIFACT_TO_RELATIVE_PATH);
+  }
+
+  private RuleIdeInfo getRuleInfoAndVerifyLabel(
+      String target, Map<String, RuleIdeInfo> ruleIdeInfos) {
+    RuleIdeInfo ruleIdeInfo = ruleIdeInfos.get(target);
+    assertThat(ruleIdeInfo.getLabel()).isEqualTo(target);
+    return ruleIdeInfo;
+  }
+
+  public void testJavaLibraryProtoWithDependencies() throws Exception {
+    scratch.file(
+        "com/google/example/BUILD",
+        "java_library(",
+        "    name = \"simple\",",
+        "    srcs = [\"simple/Simple.java\"]",
+        ")",
+        "java_library(",
+        "    name = \"complex\",",
+        "    srcs = [\"complex/Complex.java\"],",
+        "    deps = [\":simple\"]",
+        ")");
+    String target = "//com/google/example:complex";
+    Map<String, RuleIdeInfo> ruleIdeInfos = buildRuleIdeInfo(target);
+    assertThat(ruleIdeInfos.size()).isEqualTo(2);
+
+    getRuleInfoAndVerifyLabel("//com/google/example:simple", ruleIdeInfos);
+
+    RuleIdeInfo complexRuleIdeInfo = getRuleInfoAndVerifyLabel(target, ruleIdeInfos);
+
+    assertThat(relativePathsForSourcesOf(complexRuleIdeInfo))
+        .containsExactly("com/google/example/complex/Complex.java");
+    assertThat(complexRuleIdeInfo.getDependenciesList())
+        .containsExactly("//com/google/example:simple");
+
+    assertThat(complexRuleIdeInfo.getTransitiveDependenciesList())
+        .containsExactly("//com/google/example:simple");
+  }
+
+  public void testJavaLibraryWithTransitiveDependencies() throws Exception {
+    scratch.file(
+        "com/google/example/BUILD",
+        "java_library(",
+        "    name = \"simple\",",
+        "    srcs = [\"simple/Simple.java\"]",
+        ")",
+        "java_library(",
+        "    name = \"complex\",",
+        "    srcs = [\"complex/Complex.java\"],",
+        "    deps = [\":simple\"]",
+        ")",
+        "java_library(",
+        "    name = \"extracomplex\",",
+        "    srcs = [\"extracomplex/ExtraComplex.java\"],",
+        "    deps = [\":complex\"]",
+        ")");
+    String target = "//com/google/example:extracomplex";
+    Map<String, RuleIdeInfo> ruleIdeInfos = buildRuleIdeInfo(target);
+    assertThat(ruleIdeInfos.size()).isEqualTo(3);
+
+    getRuleInfoAndVerifyLabel("//com/google/example:simple", ruleIdeInfos);
+    getRuleInfoAndVerifyLabel("//com/google/example:complex", ruleIdeInfos);
+
+    RuleIdeInfo extraComplexRuleIdeInfo = getRuleInfoAndVerifyLabel(target, ruleIdeInfos);
+
+    assertThat(relativePathsForSourcesOf(extraComplexRuleIdeInfo))
+        .containsExactly("com/google/example/extracomplex/ExtraComplex.java");
+    assertThat(extraComplexRuleIdeInfo.getDependenciesList())
+        .containsExactly("//com/google/example:complex");
+
+    assertThat(extraComplexRuleIdeInfo.getTransitiveDependenciesList())
+        .containsExactly("//com/google/example:complex", "//com/google/example:simple");
+  }
+
+  public void testJavaLibraryWithDiamondDependencies() throws Exception {
+    scratch.file(
+        "com/google/example/BUILD",
+        "java_library(",
+        "    name = \"simple\",",
+        "    srcs = [\"simple/Simple.java\"]",
+        ")",
+        "java_library(",
+        "    name = \"complex\",",
+        "    srcs = [\"complex/Complex.java\"],",
+        "    deps = [\":simple\"]",
+        ")",
+        "java_library(",
+        "    name = \"complex1\",",
+        "    srcs = [\"complex1/Complex.java\"],",
+        "    deps = [\":simple\"]",
+        ")",
+        "java_library(",
+        "    name = \"extracomplex\",",
+        "    srcs = [\"extracomplex/ExtraComplex.java\"],",
+        "    deps = [\":complex\", \":complex1\"]",
+        ")");
+    String target = "//com/google/example:extracomplex";
+    Map<String, RuleIdeInfo> ruleIdeInfos = buildRuleIdeInfo(target);
+    assertThat(ruleIdeInfos.size()).isEqualTo(4);
+
+    getRuleInfoAndVerifyLabel("//com/google/example:simple", ruleIdeInfos);
+    getRuleInfoAndVerifyLabel("//com/google/example:complex", ruleIdeInfos);
+    getRuleInfoAndVerifyLabel("//com/google/example:complex1", ruleIdeInfos);
+
+    RuleIdeInfo extraComplexRuleIdeInfo = getRuleInfoAndVerifyLabel(target, ruleIdeInfos);
+
+    assertThat(relativePathsForSourcesOf(extraComplexRuleIdeInfo))
+        .containsExactly("com/google/example/extracomplex/ExtraComplex.java");
+    assertThat(extraComplexRuleIdeInfo.getDependenciesList())
+        .containsExactly("//com/google/example:complex", "//com/google/example:complex1");
+
+    assertThat(extraComplexRuleIdeInfo.getTransitiveDependenciesList())
+        .containsExactly(
+            "//com/google/example:complex",
+            "//com/google/example:complex1",
+            "//com/google/example:simple");
+  }
+
+  public void testJavaLibraryWithExports() throws Exception {
+    scratch.file(
+        "com/google/example/BUILD",
+        "java_library(",
+        "    name = \"simple\",",
+        "    srcs = [\"simple/Simple.java\"]",
+        ")",
+        "java_library(",
+        "    name = \"complex\",",
+        "    srcs = [\"complex/Complex.java\"],",
+        "    deps = [\":simple\"],",
+        "    exports = [\":simple\"],",
+        ")",
+        "java_library(",
+        "    name = \"extracomplex\",",
+        "    srcs = [\"extracomplex/ExtraComplex.java\"],",
+        "    deps = [\":complex\"]",
+        ")");
+    String target = "//com/google/example:extracomplex";
+    Map<String, RuleIdeInfo> ruleIdeInfos = buildRuleIdeInfo(target);
+    assertThat(ruleIdeInfos.size()).isEqualTo(3);
+
+    getRuleInfoAndVerifyLabel("//com/google/example:simple", ruleIdeInfos);
+    getRuleInfoAndVerifyLabel("//com/google/example:complex", ruleIdeInfos);
+
+    RuleIdeInfo extraComplexRuleIdeInfo = getRuleInfoAndVerifyLabel(target, ruleIdeInfos);
+
+    assertThat(relativePathsForSourcesOf(extraComplexRuleIdeInfo))
+        .containsExactly("com/google/example/extracomplex/ExtraComplex.java");
+    assertThat(extraComplexRuleIdeInfo.getDependenciesList())
+        .containsExactly("//com/google/example:complex", "//com/google/example:simple");
+
+    assertThat(extraComplexRuleIdeInfo.getTransitiveDependenciesList())
+        .containsExactly(
+            "//com/google/example:complex",
+            "//com/google/example:simple");
+  }
+
+  public void testJavaLibraryWithTransitiveExports() throws Exception {
+    scratch.file(
+        "com/google/example/BUILD",
+        "java_library(",
+        "    name = \"simple\",",
+        "    srcs = [\"simple/Simple.java\"]",
+        ")",
+        "java_library(",
+        "    name = \"complex\",",
+        "    srcs = [\"complex/Complex.java\"],",
+        "    deps = [\":simple\"],",
+        "    exports = [\":simple\"],",
+        ")",
+        "java_library(",
+        "    name = \"extracomplex\",",
+        "    srcs = [\"extracomplex/ExtraComplex.java\"],",
+        "    deps = [\":complex\"],",
+        "    exports = [\":complex\"],",
+        ")",
+        "java_library(",
+        "    name = \"megacomplex\",",
+        "    srcs = [\"megacomplex/MegaComplex.java\"],",
+        "    deps = [\":extracomplex\"],",
+        ")"
+    );
+    String target = "//com/google/example:megacomplex";
+    Map<String, RuleIdeInfo> ruleIdeInfos = buildRuleIdeInfo(target);
+    assertThat(ruleIdeInfos.size()).isEqualTo(4);
+
+    getRuleInfoAndVerifyLabel("//com/google/example:simple", ruleIdeInfos);
+    getRuleInfoAndVerifyLabel("//com/google/example:complex", ruleIdeInfos);
+    getRuleInfoAndVerifyLabel("//com/google/example:extracomplex", ruleIdeInfos);
+
+    RuleIdeInfo megaComplexRuleIdeInfo = getRuleInfoAndVerifyLabel(target, ruleIdeInfos);
+
+    assertThat(relativePathsForSourcesOf(megaComplexRuleIdeInfo))
+        .containsExactly("com/google/example/megacomplex/MegaComplex.java");
+    assertThat(megaComplexRuleIdeInfo.getDependenciesList())
+        .containsExactly(
+            "//com/google/example:extracomplex",
+            "//com/google/example:complex",
+            "//com/google/example:simple");
+
+    assertThat(megaComplexRuleIdeInfo.getTransitiveDependenciesList())
+        .containsExactly(
+            "//com/google/example:extracomplex",
+            "//com/google/example:complex",
+            "//com/google/example:simple");
+  }
+
+  private Map<String, RuleIdeInfo> buildRuleIdeInfo(String target) throws Exception {
+    AnalysisResult analysisResult =
+        update(
+            ImmutableList.of(target),
+            ImmutableList.of(AndroidStudioInfoAspect.NAME),
+            false,
+            LOADING_PHASE_THREADS,
+            true,
+            new EventBus());
+    Collection<AspectValue> aspects = analysisResult.getAspects();
+    assertThat(aspects.size()).isEqualTo(1);
+    AspectValue value = aspects.iterator().next();
+    assertThat(value.getAspect().getName()).isEqualTo(AndroidStudioInfoAspect.NAME);
+    AndroidStudioInfoFilesProvider provider =
+        value.getAspect().getProvider(AndroidStudioInfoFilesProvider.class);
+    Iterable<Artifact> artifacts = provider.getIdeBuildFiles();
+    ImmutableMap.Builder<String, RuleIdeInfo> builder = ImmutableMap.builder();
+    for (Artifact artifact : artifacts) {
+      BinaryFileWriteAction generatingAction =
+          (BinaryFileWriteAction) getGeneratingAction(artifact);
+      RuleIdeInfo ruleIdeInfo = RuleIdeInfo.parseFrom(generatingAction.getSource().openStream());
+      builder.put(ruleIdeInfo.getLabel(), ruleIdeInfo);
+    }
+    return builder.build();
+  }
+}