Fix NPE when maven_jar sha1 isn't set and caching is enabled

--
MOS_MIGRATED_REVID=138669967

1 files changed, 19 insertions, 0 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/bazel/repository/MavenJarFunctionTest.java b/src/test/java/com/google/devtools/build/lib/bazel/repository/MavenJarFunctionTest.java
index 61e8023e27..8b90c612df 100644
--- a/src/test/java/com/google/devtools/build/lib/bazel/repository/MavenJarFunctionTest.java
+++ b/src/test/java/com/google/devtools/build/lib/bazel/repository/MavenJarFunctionTest.java
@@ -93,4 +93,23 @@ public class MavenJarFunctionTest extends BuildViewTestCase {
       assertThat(expected.getMessage()).contains("Failed to fetch Maven dependency:");
     }
   }
+
+  @Test
+  public void testNoSha1WithCache() throws Exception {
+    Rule rule = scratchRule("external", "foo",
+        "maven_jar(",
+        "    name = 'foo',",
+        "    artifact = 'x:y:z:1.1',",
+        ")");
+    RepositoryCache cache = Mockito.mock(RepositoryCache.class);
+    Mockito.when(cache.isEnabled()).thenReturn(true);
+    MavenDownloader downloader = new MavenDownloader(cache);
+    try {
+      downloader.download(
+          "foo", WorkspaceAttributeMapper.of(rule), scratch.dir("/whatever"), TEST_SERVER);
+      fail("Expected failure to fetch artifact because of nonexistent server.");
+    } catch (IOException expected) {
+      assertThat(expected.getMessage()).contains("Failed to fetch Maven dependency:");
+    }
+  }
 }