aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/test/java/com
diff options
context:
space:
mode:
authorGravatar dslomov <dslomov@google.com>2017-08-04 17:32:47 +0200
committerGravatar Jakob Buchgraber <buchgr@google.com>2017-08-07 11:20:10 +0200
commitce59d4dc6c7ea461c2945e80e508fa7b4d2c7c4e (patch)
treeb82c76a397f86b99521fb26a59ba6ab4232fc33a /src/test/java/com
parent05f563a97581959db5da0cb02daf87cfa20c6b88 (diff)
Aspects that apply to files cannot apply to source files.
Make them not crash. RELNOTES: None. PiperOrigin-RevId: 164265379
Diffstat (limited to 'src/test/java/com')
-rw-r--r--src/test/java/com/google/devtools/build/lib/analysis/AspectTest.java22
1 files changed, 21 insertions, 1 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/analysis/AspectTest.java b/src/test/java/com/google/devtools/build/lib/analysis/AspectTest.java
index a2bac61ceb..4488f733c8 100644
--- a/src/test/java/com/google/devtools/build/lib/analysis/AspectTest.java
+++ b/src/test/java/com/google/devtools/build/lib/analysis/AspectTest.java
@@ -800,7 +800,7 @@ public class AspectTest extends AnalysisTestCase {
}
@Test
- public void aspectApplyingtToFiles() throws Exception {
+ public void aspectApplyingToFiles() throws Exception {
AspectApplyingToFiles aspectApplyingToFiles = new AspectApplyingToFiles();
setRulesAndAspectsAvailableInTests(
ImmutableList.<NativeAspectClass>of(aspectApplyingToFiles),
@@ -818,4 +818,24 @@ public class AspectTest extends AnalysisTestCase {
assertThat(provider.getLabel())
.isEqualTo(Label.parseAbsoluteUnchecked("//a:x_deploy.jar"));
}
+
+ @Test
+ public void aspectApplyingToSourceFilesIgnored() throws Exception {
+ AspectApplyingToFiles aspectApplyingToFiles = new AspectApplyingToFiles();
+ setRulesAndAspectsAvailableInTests(
+ ImmutableList.<NativeAspectClass>of(aspectApplyingToFiles),
+ ImmutableList.<RuleDefinition>of());
+ pkg(
+ "a",
+ "java_binary(name = 'x', main_class = 'x.FooBar', srcs = ['x.java'])"
+ );
+ scratch.file("a/x.java", "");
+ AnalysisResult analysisResult = update(new EventBus(), defaultFlags(),
+ ImmutableList.of(aspectApplyingToFiles.getName()),
+ "//a:x.java");
+ AspectValue aspect = Iterables.getOnlyElement(analysisResult.getAspects());
+ assertThat(aspect.getConfiguredAspect().getProvider(AspectApplyingToFiles.Provider.class))
+ .isNull();
+ }
+
}