Migrate UnixGlob to Path#statIfFound() instead of #statNullable(). The latter swallows all filesystem failures, and does not disambiguate missing files from filesystem problems.

The syscall cache now tracks IOExceptions if they are present, just as it does with readdir().

RELNOTES: None
PiperOrigin-RevId: 153185433

1 files changed, 27 insertions, 2 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/vfs/GlobTest.java b/src/test/java/com/google/devtools/build/lib/vfs/GlobTest.java
index 430078ae86..c74e61d3b1 100644
--- a/src/test/java/com/google/devtools/build/lib/vfs/GlobTest.java
+++ b/src/test/java/com/google/devtools/build/lib/vfs/GlobTest.java
@@ -185,11 +185,36 @@ public class GlobTest {
   }
 
   @Test
+  public void testIOFailureOnStat() throws Exception {
+    UnixGlob.FilesystemCalls syscalls = new UnixGlob.FilesystemCalls() {
+      @Override
+      public FileStatus statIfFound(Path path, Symlinks symlinks) throws IOException {
+        throw new IOException("EIO");
+      }
+
+      @Override
+      public Collection<Dirent> readdir(Path path, Symlinks symlinks) {
+        throw new IllegalStateException();
+      }
+    };
+
+    try {
+      new UnixGlob.Builder(tmpPath)
+          .addPattern("foo/bar/wiz/file")
+          .setFilesystemCalls(new AtomicReference<>(syscalls))
+          .glob();
+      fail("Expected failure");
+    } catch (IOException e) {
+      assertThat(e).hasMessageThat().isEqualTo("EIO");
+    }
+  }
+
+  @Test
   public void testGlobWithoutWildcardsDoesNotCallReaddir() throws Exception {
     UnixGlob.FilesystemCalls syscalls = new UnixGlob.FilesystemCalls() {
       @Override
-      public FileStatus statNullable(Path path, Symlinks symlinks) {
-        return UnixGlob.DEFAULT_SYSCALLS.statNullable(path, symlinks);
+      public FileStatus statIfFound(Path path, Symlinks symlinks) throws IOException {
+        return UnixGlob.DEFAULT_SYSCALLS.statIfFound(path, symlinks);
       }
 
       @Override