aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/test/java/com
diff options
context:
space:
mode:
authorGravatar tomlu <tomlu@google.com>2018-05-30 08:42:26 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-05-30 08:43:41 -0700
commit735627fd1753f7a7a9da7c06487ffe4451133abe (patch)
tree65639cf556fbcf7957b98314312e7659e0d9c791 /src/test/java/com
parent15e0fa8342afb1a6c718958f2789c2e6b60f8e92 (diff)
Fix a few tests when run under JDK9.
RELNOTES: None PiperOrigin-RevId: 198565423
Diffstat (limited to 'src/test/java/com')
-rw-r--r--src/test/java/com/google/devtools/build/lib/analysis/select/RawAttributeMapperTest.java4
-rw-r--r--src/test/java/com/google/devtools/build/lib/testutil/MoreAsserts.java10
2 files changed, 11 insertions, 3 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/analysis/select/RawAttributeMapperTest.java b/src/test/java/com/google/devtools/build/lib/analysis/select/RawAttributeMapperTest.java
index f1bf25497d..e1d3045fc3 100644
--- a/src/test/java/com/google/devtools/build/lib/analysis/select/RawAttributeMapperTest.java
+++ b/src/test/java/com/google/devtools/build/lib/analysis/select/RawAttributeMapperTest.java
@@ -69,7 +69,7 @@ public class RawAttributeMapperTest extends AbstractAttributeMapperTest {
assertThat(e)
.hasCauseThat()
.hasMessageThat()
- .contains("SelectorList cannot be cast to java.util.List");
+ .containsMatch(".*SelectorList cannot be cast to .*java\\.util\\.List");
}
}
@@ -107,7 +107,7 @@ public class RawAttributeMapperTest extends AbstractAttributeMapperTest {
assertThat(e)
.hasCauseThat()
.hasMessageThat()
- .contains("SelectorList cannot be cast to java.util.List");
+ .containsMatch(".*SelectorList cannot be cast to .*java\\.util\\.List");
}
}
diff --git a/src/test/java/com/google/devtools/build/lib/testutil/MoreAsserts.java b/src/test/java/com/google/devtools/build/lib/testutil/MoreAsserts.java
index 85b3b7934d..990a4177bb 100644
--- a/src/test/java/com/google/devtools/build/lib/testutil/MoreAsserts.java
+++ b/src/test/java/com/google/devtools/build/lib/testutil/MoreAsserts.java
@@ -117,7 +117,15 @@ public class MoreAsserts {
continue;
}
- f.setAccessible(true);
+ try {
+ f.setAccessible(true);
+ } catch (RuntimeException e) {
+ // JDK9 can throw InaccessibleObjectException when internal modules are accessed.
+ // This isn't available in JDK8, so catch RuntimeException
+ // We can use a JVM arg --add_opens to suppress that, but that involves every
+ // test adding every JVM module to the target.
+ continue;
+ }
try {
Object ref = f.get(current);
if (ref != null) {