diff options
| author |  lberki <lberki@google.com> | 2017-05-23 10:16:19 +0200 |
|---|---|---|
| committer |  Irina Iancu <elenairina@google.com> | 2017-05-23 12:48:00 +0200 |
| commit | 71c82076f9d4ad84810050bc350e414b3297286a (patch) | |
| tree | d7e58c7cc042daea8bbf952099f2a4ed8582f500 /src/test/java/com | |
| parent | 32e66548d10a55e182742353a2b35091fe871936 (diff) | |
Add a #hashCode() method to WorkspaceStatusAction implementations as is advisable when overriding #equals().
Intricacies within Skyframe prevented us from adding this method before, but whatever those were are not a problem anymore. This was empirically proven by making the change, looking at the set of tests that failed when I last tried this, then finding that they don't fail.
The reason for the original failures will stay obscured by the mists of time forever.
RELNOTES: None.
PiperOrigin-RevId: 156835875
Diffstat (limited to 'src/test/java/com')
| -rw-r--r-- | src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestUtil.java | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestUtil.java b/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestUtil.java index ac5b37652b..f710c33ba0 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestUtil.java +++ b/src/test/java/com/google/devtools/build/lib/analysis/util/AnalysisTestUtil.java @@ -250,8 +250,7 @@ public final class AnalysisTestUtil { @Override public int hashCode() { - // TODO(b/38132001): return key.hashCode(); - return System.identityHashCode(this); + return key.hashCode(); } } |