Allow absolute symlinks in TreeArtifacts. Let the downstream action (if there is one) worry about it.

--
PiperOrigin-RevId: 148249223
MOS_MIGRATED_REVID=148249223

1 files changed, 28 insertions, 3 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/skyframe/TreeArtifactBuildTest.java b/src/test/java/com/google/devtools/build/lib/skyframe/TreeArtifactBuildTest.java
index 307e4a68d9..099b307116 100644
--- a/src/test/java/com/google/devtools/build/lib/skyframe/TreeArtifactBuildTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skyframe/TreeArtifactBuildTest.java
@@ -564,7 +564,7 @@ public class TreeArtifactBuildTest extends TimestampBuilderTestCase {
   }
 
   @Test
-  public void testAbsoluteSymlinkRejected() throws Exception {
+  public void testAbsoluteSymlinkBadTargetRejected() throws Exception {
     // Failure expected
     StoredEventHandler storingEventHandler = new StoredEventHandler();
     reporter.removeHandler(failFastHandler);
@@ -596,13 +596,38 @@ public class TreeArtifactBuildTest extends TimestampBuilderTestCase {
       List<Event> errors = ImmutableList.copyOf(
           Iterables.filter(storingEventHandler.getEvents(), IS_ERROR_EVENT));
       assertThat(errors).hasSize(2);
-      assertThat(errors.get(0).getMessage()).contains(
-          "A TreeArtifact may not contain absolute symlinks");
+      assertThat(errors.get(0).getMessage()).contains("Failed to resolve relative path links/link");
       assertThat(errors.get(1).getMessage()).contains("not all outputs were created or valid");
     }
   }
 
   @Test
+  public void testAbsoluteSymlinkAccepted() throws Exception {
+    scratch.overwriteFile("/random/pointer");
+
+    final Artifact out = createTreeArtifact("output");
+
+    TreeArtifactTestAction action =
+        new TreeArtifactTestAction(out) {
+          @Override
+          public void execute(ActionExecutionContext actionExecutionContext) {
+            try {
+              writeFile(out.getPath().getChild("one"), "one");
+              writeFile(out.getPath().getChild("two"), "two");
+              FileSystemUtils.ensureSymbolicLink(
+                  out.getPath().getChild("links").getChild("link"), "/random/pointer");
+            } catch (Exception e) {
+              throw new RuntimeException(e);
+            }
+          }
+        };
+
+    registerAction(action);
+
+    buildArtifact(action.getSoleOutput());
+  }
+
+  @Test
   public void testRelativeSymlinkTraversingOutsideOfTreeArtifactRejected() throws Exception {
     // Failure expected
     StoredEventHandler storingEventHandler = new StoredEventHandler();