aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/test/java/com
diff options
context:
space:
mode:
authorGravatar cparsons <cparsons@google.com>2018-07-13 11:47:17 -0700
committerGravatar Copybara-Service <copybara-piper@google.com>2018-07-13 11:48:44 -0700
commit23aab171d93d7a6a0945b64fecf3e2094626e1fc (patch)
tree71225019cc278c8faed35dd86d8b4b959b294b55 /src/test/java/com
parent32e9fee4e2192a340d0b1823538bf8e9fdf92b65 (diff)
Remove SkylarkCallable.mandatoryPositionals
RELNOTES: None. PiperOrigin-RevId: 204505003
Diffstat (limited to 'src/test/java/com')
-rw-r--r--src/test/java/com/google/devtools/build/docgen/SkylarkDocumentationTest.java8
-rw-r--r--src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java4
2 files changed, 5 insertions, 7 deletions
diff --git a/src/test/java/com/google/devtools/build/docgen/SkylarkDocumentationTest.java b/src/test/java/com/google/devtools/build/docgen/SkylarkDocumentationTest.java
index 4bca09cae3..412a74e6c4 100644
--- a/src/test/java/com/google/devtools/build/docgen/SkylarkDocumentationTest.java
+++ b/src/test/java/com/google/devtools/build/docgen/SkylarkDocumentationTest.java
@@ -149,8 +149,8 @@ public class SkylarkDocumentationTest extends SkylarkTestCase {
@SkylarkCallable(
name = "test",
doc = "MockClassD#test",
- mandatoryPositionals = 1,
parameters = {
+ @Param(name = "a"),
@Param(name = "b"),
@Param(name = "c", named = true, positional = false),
@Param(name = "d", named = true, positional = false, defaultValue = "1"),
@@ -379,10 +379,8 @@ public class SkylarkDocumentationTest extends SkylarkTestCase {
assertThat(methodDoc.getDocumentation()).isEqualTo("MockClassD#test");
assertThat(methodDoc.getSignature())
.isEqualTo(
- "<a class=\"anchor\" href=\"int.html\">int</a> "
- + "MockClassD.test(arg0:<a class=\"anchor\" href=\"int.html\">int</a>, "
- + "b, *, c, d=1)");
- assertThat(methodDoc.getParams()).hasSize(3);
+ "<a class=\"anchor\" href=\"int.html\">int</a> MockClassD.test(a, b, *, c, d=1)");
+ assertThat(methodDoc.getParams()).hasSize(4);
}
@Test
diff --git a/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java b/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
index e70a9c5a6e..ecbe65cec5 100644
--- a/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
+++ b/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
@@ -209,8 +209,8 @@ public class SkylarkEvaluationTest extends EvaluationTest {
@SkylarkCallable(
name = "with_params",
documented = false,
- mandatoryPositionals = 1,
parameters = {
+ @Param(name = "pos1"),
@Param(name = "pos2", defaultValue = "False", type = Boolean.class),
@Param(
name = "posOrNamed",
@@ -306,8 +306,8 @@ public class SkylarkEvaluationTest extends EvaluationTest {
@SkylarkCallable(
name = "with_params_and_extra",
documented = false,
- mandatoryPositionals = 1,
parameters = {
+ @Param(name = "pos1"),
@Param(name = "pos2", defaultValue = "False", type = Boolean.class),
@Param(
name = "posOrNamed",