Allow heterogeneous lists in Skylark.

This brings consistency between BUILD and Skylark interpreters. It also brings
consistency with dicts (e.g. **kwargs can contain anything and kwargs.values
is allowed).

--
MOS_MIGRATED_REVID=100278980

1 files changed, 2 insertions, 5 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java b/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
index 744e6db31b..575e0a67d7 100644
--- a/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
+++ b/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
@@ -867,15 +867,12 @@ public class SkylarkEvaluationTest extends EvaluationTest {
 
   @Test
   public void testCannotCreateMixedListInSkylark() throws Exception {
-    new SkylarkTest().update("mock", new Mock()).testIfExactError(
-        "Incompatible types in list: found a int but the previous elements were strings",
-        "[mock.string(), 1, 2]");
+    new SkylarkTest().testExactOrder("['a', 'b', 1, 2]", "a", "b", 1, 2);
   }
 
   @Test
   public void testCannotConcatListInSkylarkWithDifferentGenericTypes() throws Exception {
-    new SkylarkTest().update("mock", new Mock()).testIfExactError(
-        "cannot concatenate list of string with list of int", "mock.string_list() + [1, 2]");
+    new SkylarkTest().testExactOrder("[1, 2] + ['a', 'b']", 1, 2, "a", "b");
   }
 
   @Test