diff options
| author |  cushon <cushon@google.com> | 2017-08-07 16:26:53 +0200 |
|---|---|---|
| committer |  Marcel Hlopko <hlopko@google.com> | 2017-08-08 13:02:01 +0200 |
| commit | dc8325b98d1811f4e8b458e8f4f9660e0bc588de (patch) | |
| tree | 399e399468dea82825b89fa1d1173c9f75525444 /src/test/java/com/google | |
| parent | 2f120f780b1e02e844403b337563fcfa77e43c4a (diff) | |
Clean up expected exception tests
in preparation for a change[]
Previously calls to @CheckReturnValue-annotated methods were ignored in tests
that used ExpectedException. The enforcement is being changed to only ignore
calls that immediately follow a call to ExpectedException#expect to improve
performance.
Also note that using `assertThrows` or `expectThrows` instead of
`ExpectedException` is now strongly recommended:
[]
Tested:
TAP --sample for global presubmit queue
[]
PiperOrigin-RevId: 164457920
Diffstat (limited to 'src/test/java/com/google')
| -rw-r--r-- | src/test/java/com/google/devtools/build/lib/bazel/repository/downloader/HttpConnectorMultiplexerIntegrationTest.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/bazel/repository/downloader/HttpConnectorMultiplexerIntegrationTest.java b/src/test/java/com/google/devtools/build/lib/bazel/repository/downloader/HttpConnectorMultiplexerIntegrationTest.java index 875501b2c7..df81dbe77a 100644 --- a/src/test/java/com/google/devtools/build/lib/bazel/repository/downloader/HttpConnectorMultiplexerIntegrationTest.java +++ b/src/test/java/com/google/devtools/build/lib/bazel/repository/downloader/HttpConnectorMultiplexerIntegrationTest.java @@ -203,7 +203,7 @@ public class HttpConnectorMultiplexerIntegrationTest { ServerSocket server2 = new ServerSocket(0, 1, InetAddress.getByName(null)); ServerSocket server3 = new ServerSocket(0, 1, InetAddress.getByName(null))) { for (final ServerSocket server : asList(server1, server2, server3)) { - executor.submit( + Future<?> unused = executor.submit( new Callable<Object>() { @Override public Object call() throws Exception { |