Add codec for Object[]. This may be useful for NestedSetCodec, pushing up so that my uncommitted change chain is a little more manageable.

Unfortunately we can't get rid of the array marshaller because this only handles Object[], not any other type of array.

PiperOrigin-RevId: 191662535

1 files changed, 51 insertions, 0 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/skyframe/serialization/ArrayCodecTest.java b/src/test/java/com/google/devtools/build/lib/skyframe/serialization/ArrayCodecTest.java
new file mode 100644
index 0000000000..c12e228941
--- /dev/null
+++ b/src/test/java/com/google/devtools/build/lib/skyframe/serialization/ArrayCodecTest.java
@@ -0,0 +1,51 @@
+// Copyright 2018 The Bazel Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package com.google.devtools.build.lib.skyframe.serialization;
+
+import static com.google.common.truth.Truth.assertThat;
+
+import com.google.devtools.build.lib.skyframe.serialization.testutils.SerializationTester;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+
+/** Tests for {@link ArrayCodec}. */
+@RunWith(JUnit4.class)
+public class ArrayCodecTest {
+  @Test
+  public void smoke() throws Exception {
+    Object[] instance = new Object[2];
+    instance[0] = "hi";
+    Object[] inner = new Object[2];
+    inner[0] = "inner1";
+    inner[1] = null;
+    instance[1] = inner;
+    new SerializationTester(new Object[0], instance)
+        .setVerificationFunction(ArrayCodecTest::verifyDeserialized)
+        .runTests();
+  }
+
+  private static void verifyDeserialized(Object[] original, Object[] deserialized) {
+    assertThat(deserialized).hasLength(original.length);
+    for (int i = 0; i < deserialized.length; i++) {
+      if (original[i] instanceof Object[]) {
+        assertThat(deserialized[i]).isInstanceOf(Object[].class);
+        verifyDeserialized((Object[]) original[i], (Object[]) deserialized[i]);
+      } else {
+        assertThat(deserialized[i]).isEqualTo(original[i]);
+      }
+    }
+  }
+}