diff options
author | Janak Ramakrishnan <janakr@google.com> | 2016-03-18 15:44:28 +0000 |
---|---|---|
committer | Damien Martin-Guillerez <dmarting@google.com> | 2016-03-21 09:33:23 +0000 |
commit | a9b88ae448644137c0b15d83e117b84072a80d2f (patch) | |
tree | 29ef454c0f94fdb5ce5e238113a489003c49f7e7 /src/test/java/com/google | |
parent | f0cc5b838b851d3f2872492ce5e1441738c29105 (diff) |
RELNOTES: Bazel warns if a cc rule's includes attribute contains up-level references that escape its package.
--
MOS_MIGRATED_REVID=117550535
Diffstat (limited to 'src/test/java/com/google')
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonConfiguredTargetTest.java | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonConfiguredTargetTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonConfiguredTargetTest.java index aa06687265..65e3044aa1 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonConfiguredTargetTest.java +++ b/src/test/java/com/google/devtools/build/lib/rules/cpp/CcCommonConfiguredTargetTest.java @@ -505,6 +505,21 @@ public class CcCommonConfiguredTargetTest extends BuildViewTestCase { } @Test + public void testCcLibraryUplevelIncludesWarned() throws Exception { + checkWarning( + "uplevel", + "lib", + // message: + "in includes attribute of cc_library rule //uplevel:lib: '../bar' resolves to 'bar' not " + + "below the relative path of its package 'uplevel'. This will be an error in the " + + "future", + // build file: + "cc_library(name = 'lib',", + " srcs = ['foo.cc'],", + " includes = ['../bar'])"); + } + + @Test public void testStaticallyLinkedBinaryNeedsSharedObject() throws Exception { scratch.file( "third_party/sophos_av_pua/BUILD", |