Raise error in function calls when star argument is not iterable

This was a bug, f(*4) was silently handled as f().

--
PiperOrigin-RevId: 148017021
MOS_MIGRATED_REVID=148017021

1 files changed, 13 insertions, 0 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/syntax/FunctionTest.java b/src/test/java/com/google/devtools/build/lib/syntax/FunctionTest.java
index 2f29dfd1d4..095964344e 100644
--- a/src/test/java/com/google/devtools/build/lib/syntax/FunctionTest.java
+++ b/src/test/java/com/google/devtools/build/lib/syntax/FunctionTest.java
@@ -308,6 +308,19 @@ public class FunctionTest extends EvaluationTestCase {
   }
 
   @Test
+  public void testArgsIsNotIterable() throws Exception {
+    checkEvalError(
+        "argument after * must be an iterable, not int",
+        "def func1(a, b): return a + b",
+        "func1('a', *42)");
+
+    checkEvalError(
+        "argument after * must be an iterable, not string",
+        "def func2(a, b): return a + b",
+        "func2('a', *'str')");
+  }
+
+  @Test
   public void testKwargs() throws Exception {
     eval("def foo(a, b = 'b', *, c, d = 'd'):",
       "  return a + b + c + d",