Make SymlinkTreeAction properly use the configuration's environment

In particular, fix its use of client make variables.

Fixes #4750.

PiperOrigin-RevId: 197545415

1 files changed, 71 insertions, 0 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/analysis/actions/SymlinkTreeActionTest.java b/src/test/java/com/google/devtools/build/lib/analysis/actions/SymlinkTreeActionTest.java
new file mode 100644
index 0000000000..9c61d541b4
--- /dev/null
+++ b/src/test/java/com/google/devtools/build/lib/analysis/actions/SymlinkTreeActionTest.java
@@ -0,0 +1,71 @@
+// Copyright 2018 The Bazel Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//    http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package com.google.devtools.build.lib.analysis.actions;
+
+import com.google.common.collect.ImmutableMap;
+import com.google.common.collect.ImmutableSet;
+import com.google.devtools.build.lib.actions.Action;
+import com.google.devtools.build.lib.actions.ActionEnvironment;
+import com.google.devtools.build.lib.actions.Artifact;
+import com.google.devtools.build.lib.actions.util.ActionsTestUtil;
+import com.google.devtools.build.lib.analysis.util.ActionTester;
+import com.google.devtools.build.lib.analysis.util.ActionTester.ActionCombinationFactory;
+import com.google.devtools.build.lib.analysis.util.BuildViewTestCase;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+
+/**
+ * Tests {@link SymlinkTreeAction}.
+ */
+@RunWith(JUnit4.class)
+public class SymlinkTreeActionTest extends BuildViewTestCase {
+  private enum KeyAttributes {
+    FILESET,
+    RUNFILES,
+    FIXED_ENVIRONMENT,
+    VARIABLE_ENVIRONMENT
+  }
+
+  @Test
+  public void testComputeKey() throws Exception {
+    final Artifact inputManifest = getBinArtifactWithNoOwner("dir/manifest.in");
+    final Artifact outputManifest = getBinArtifactWithNoOwner("dir/MANIFEST");
+
+    ActionTester.runTest(
+        KeyAttributes.class,
+        new ActionCombinationFactory<KeyAttributes>() {
+          @Override
+          public Action generate(ImmutableSet<KeyAttributes> attributesToFlip) {
+            boolean filesetTree = attributesToFlip.contains(KeyAttributes.FILESET);
+            boolean enableRunfiles = attributesToFlip.contains(KeyAttributes.RUNFILES);
+
+            ActionEnvironment env = ActionEnvironment.create(
+                attributesToFlip.contains(KeyAttributes.FIXED_ENVIRONMENT)
+                    ? ImmutableMap.of("a", "b") : ImmutableMap.of(),
+                attributesToFlip.contains(KeyAttributes.VARIABLE_ENVIRONMENT)
+                    ? ImmutableSet.of("c") : ImmutableSet.of());
+
+            return new SymlinkTreeAction(
+                ActionsTestUtil.NULL_ACTION_OWNER,
+                inputManifest,
+                outputManifest,
+                filesetTree,
+                env,
+                enableRunfiles);
+          }
+        },
+        actionKeyContext);
+  }
+}