diff options
author | 2018-06-27 08:58:01 -0700 | |
---|---|---|
committer | 2018-06-27 08:59:30 -0700 | |
commit | 2e7125529178144e50f10fc60e37d35003770fce (patch) | |
tree | fb6f03da71c5f0d239c0ece6ab3e10f5453f0030 /src/test/java/com/google | |
parent | 49eaa8f01065ee12e4726d818e24a8c594878e10 (diff) |
Debug server logging: don't construct expensive debug-level log strings unless necessary.
PiperOrigin-RevId: 202317115
Diffstat (limited to 'src/test/java/com/google')
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/skylarkdebug/server/DebugServerTransportTest.java | 18 |
1 files changed, 4 insertions, 14 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/skylarkdebug/server/DebugServerTransportTest.java b/src/test/java/com/google/devtools/build/lib/skylarkdebug/server/DebugServerTransportTest.java index 2dcdf2543e..e5c119deaa 100644 --- a/src/test/java/com/google/devtools/build/lib/skylarkdebug/server/DebugServerTransportTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylarkdebug/server/DebugServerTransportTest.java @@ -16,7 +16,6 @@ package com.google.devtools.build.lib.skylarkdebug.server; import static com.google.common.truth.Truth.assertThat; -import com.google.devtools.build.lib.events.EventHandler; import com.google.devtools.build.lib.events.EventKind; import com.google.devtools.build.lib.events.util.EventCollectionApparatus; import com.google.devtools.build.lib.skylarkdebugging.SkylarkDebuggingProtos.ContinueExecutionResponse; @@ -48,17 +47,6 @@ public class DebugServerTransportTest { private final EventCollectionApparatus events = new EventCollectionApparatus(EventKind.ALL_EVENTS); - /** - * The default fail-fast {@link EventHandler} fails on debug-level events, so we instead use a - * handler suppressing those events. - */ - private final EventHandler eventHandler = - event -> { - if (event.getKind() != EventKind.DEBUG) { - events.reporter().handle(event); - } - }; - /** A simple debug client for testing purposes. */ private static class MockDebugClient { @@ -100,7 +88,8 @@ public class DebugServerTransportTest { Future<DebugServerTransport> future = executor.submit( () -> - DebugServerTransport.createAndWaitForClient(eventHandler, serverSocket)); + DebugServerTransport.createAndWaitForClient( + events.reporter(), serverSocket, false)); MockDebugClient client = new MockDebugClient(); client.connect(Duration.ofSeconds(10), serverSocket); @@ -123,7 +112,8 @@ public class DebugServerTransportTest { Future<DebugServerTransport> future = executor.submit( () -> - DebugServerTransport.createAndWaitForClient(eventHandler, serverSocket)); + DebugServerTransport.createAndWaitForClient( + events.reporter(), serverSocket, false)); MockDebugClient client = new MockDebugClient(); client.connect(Duration.ofSeconds(10), serverSocket); |