diff options
author | vladmos <vladmos@google.com> | 2017-04-14 16:34:15 +0200 |
---|---|---|
committer | Klaus Aehlig <aehlig@google.com> | 2017-04-18 11:26:41 +0200 |
commit | 1341e3ed45045b85cda2c57c0623dae0d7149b16 (patch) | |
tree | ef7104e94efa4b18a4b665bb239f51a0babfb519 /src/test/java/com/google | |
parent | 1637af9b570197de5e8df888e4eb95fcf7c95234 (diff) |
Fix `in` operator for targets
`DefaultInfo in target` should always return `true` for any target.
PiperOrigin-RevId: 153166669
Diffstat (limited to 'src/test/java/com/google')
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java index 0d4f74fe8c..8c4be30028 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java @@ -867,6 +867,7 @@ public class SkylarkRuleImplementationFunctionsTest extends SkylarkTestCase { "def _impl(ctx):", " provider = ctx.attr.deps[0][DefaultInfo]", " return struct(", + " is_provided = DefaultInfo in ctx.attr.deps[0],", " provider = provider,", " dir = str(sorted(dir(provider))),", " rule_data_runfiles = provider.data_runfiles,", @@ -889,6 +890,8 @@ public class SkylarkRuleImplementationFunctionsTest extends SkylarkTestCase { ConfiguredTarget configuredTarget = getConfiguredTarget("//test:my_rule"); SkylarkProviders providers = configuredTarget.getProvider(SkylarkProviders.class); + assertThat((Boolean) providers.getValue("is_provided")).isTrue(); + Object provider = providers.getValue("provider"); assertThat(provider).isInstanceOf(DefaultProvider.class); assertThat(((DefaultProvider) provider).getConstructor().getPrintableName()) @@ -925,6 +928,7 @@ public class SkylarkRuleImplementationFunctionsTest extends SkylarkTestCase { "def _impl(ctx):", " provider = ctx.attr.deps[0][DefaultInfo]", " return struct(", + " is_provided = DefaultInfo in ctx.attr.deps[0],", " provider = provider,", " dir = str(sorted(dir(provider))),", " file_data_runfiles = provider.data_runfiles,", @@ -945,6 +949,8 @@ public class SkylarkRuleImplementationFunctionsTest extends SkylarkTestCase { ConfiguredTarget configuredTarget = getConfiguredTarget("//test:my_rule"); SkylarkProviders providers = configuredTarget.getProvider(SkylarkProviders.class); + assertThat((Boolean) providers.getValue("is_provided")).isTrue(); + Object provider = providers.getValue("provider"); assertThat(provider).isInstanceOf(DefaultProvider.class); assertThat(((DefaultProvider) provider).getConstructor().getPrintableName()) |