aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/test/java/com/google/devtools
diff options
context:
space:
mode:
authorGravatar dannark <dannark@google.com>2018-02-10 21:54:35 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2018-02-10 21:56:02 -0800
commite3bbfdb839a483f1a418a94d857c25794006fbe0 (patch)
tree3791c9f9a70f152708e3af54c35c1803b67f0f9e /src/test/java/com/google/devtools
parentf13a7ef7c9eb7ce400ffbbaca0bdc7945172a332 (diff)
Add custom_package attribute to android_local_test.
android_local_test generates and R.class file and so this is necessary for projects that don't nest their BUILD files under a java/ or javatests/ root. Fixes #4618 RELNOTES: None PiperOrigin-RevId: 185281836
Diffstat (limited to 'src/test/java/com/google/devtools')
-rw-r--r--src/test/java/com/google/devtools/build/lib/rules/android/AndroidLocalTestTest.java19
-rw-r--r--src/test/java/com/google/devtools/build/lib/rules/android/BUILD4
2 files changed, 20 insertions, 3 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/rules/android/AndroidLocalTestTest.java b/src/test/java/com/google/devtools/build/lib/rules/android/AndroidLocalTestTest.java
index 6129129b26..34583b7dea 100644
--- a/src/test/java/com/google/devtools/build/lib/rules/android/AndroidLocalTestTest.java
+++ b/src/test/java/com/google/devtools/build/lib/rules/android/AndroidLocalTestTest.java
@@ -18,6 +18,8 @@ import static com.google.common.truth.Truth.assertThat;
import com.google.devtools.build.lib.actions.Artifact;
import com.google.devtools.build.lib.actions.util.ActionsTestUtil;
import com.google.devtools.build.lib.analysis.ConfiguredTarget;
+import com.google.devtools.build.lib.testutil.MoreAsserts;
+import java.util.List;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
@@ -111,6 +113,23 @@ public abstract class AndroidLocalTestTest extends AbstractAndroidLocalTestTestB
assertNoEvents();
}
+ @Test
+ public void testCustomPackage() throws Exception {
+ scratch.file(
+ "a/BUILD",
+ "load('//java/bar:foo.bzl', 'extra_deps')",
+ "android_local_test(name = 'dummyTest',",
+ " srcs = ['test.java'],",
+ " custom_package = 'custom.pkg',",
+ " test_class = 'test',",
+ " deps = extra_deps)");
+ ConfiguredTarget target = getConfiguredTarget("//a:dummyTest");
+ Artifact resourcesClassJar =
+ getImplicitOutputArtifact(target, AndroidRuleClasses.ANDROID_RESOURCES_CLASS_JAR);
+ List<String> args = getGeneratingSpawnActionArgs(resourcesClassJar);
+ MoreAsserts.assertContainsSublist(args, "--packageForR", "custom.pkg");
+ }
+
@Override
protected String getRuleName() {
return "android_local_test";
diff --git a/src/test/java/com/google/devtools/build/lib/rules/android/BUILD b/src/test/java/com/google/devtools/build/lib/rules/android/BUILD
index 7f93fb6374..6d23f69c22 100644
--- a/src/test/java/com/google/devtools/build/lib/rules/android/BUILD
+++ b/src/test/java/com/google/devtools/build/lib/rules/android/BUILD
@@ -318,12 +318,10 @@ java_library(
":AbstractAndroidLocalTestTestBase",
"//src/main/java/com/google/devtools/build/lib:android-rules",
"//src/main/java/com/google/devtools/build/lib:build-base",
- "//src/main/java/com/google/devtools/build/lib:java-compilation",
"//src/main/java/com/google/devtools/build/lib:util",
"//src/main/java/com/google/devtools/build/lib/actions",
- "//src/main/java/com/google/devtools/build/lib/collect/nestedset",
"//src/test/java/com/google/devtools/build/lib:actions_testutil",
- "//src/test/java/com/google/devtools/build/lib:analysis_testutil",
+ "//src/test/java/com/google/devtools/build/lib:testutil",
"//third_party:guava",
"//third_party:junit4",
"//third_party:truth",