aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/test/java/com/google/devtools
diff options
context:
space:
mode:
authorGravatar Laszlo Csomor <laszlocsomor@google.com>2018-03-08 04:27:11 -0800
committerGravatar Copybara-Service <copybara-piper@google.com>2018-03-08 04:29:16 -0800
commit63f6e2293fe8e679732d3d180afc0e781ae40241 (patch)
tree304f1eb70906799414b258dedca15e953b05c6a3 /src/test/java/com/google/devtools
parentd3e102c9fb62f4416099dc9f097a5f207aa7d442 (diff)
tests,windows: enable android.desugar.runtime
Add the c.g.d.build.android.desugar.runtime tests to the transitive closure of //src:all_windows_tests, thus running them on CI. See https://github.com/bazelbuild/bazel/issues/4292 Closes #4796. PiperOrigin-RevId: 188312286
Diffstat (limited to 'src/test/java/com/google/devtools')
-rw-r--r--src/test/java/com/google/devtools/build/android/desugar/runtime/BUILD9
-rw-r--r--src/test/java/com/google/devtools/build/android/desugar/runtime/ThrowableExtensionTestUtility.java11
2 files changed, 13 insertions, 7 deletions
diff --git a/src/test/java/com/google/devtools/build/android/desugar/runtime/BUILD b/src/test/java/com/google/devtools/build/android/desugar/runtime/BUILD
index ec2aea4ed3..28aa4639d4 100644
--- a/src/test/java/com/google/devtools/build/android/desugar/runtime/BUILD
+++ b/src/test/java/com/google/devtools/build/android/desugar/runtime/BUILD
@@ -28,9 +28,8 @@ java_test(
srcs = ["ThrowableExtensionTest.java"],
jvm_flags = [
"-Dfortest.simulated.android.sdk_int=18",
- "'-Dexpected.strategy=com.google.devtools.build.android.desugar.runtime.ThrowableExtension$$MimicDesugaringStrategy'",
+ "-Dexpected.strategy='com.google.devtools.build.android.desugar.runtime.ThrowableExtension$$MimicDesugaringStrategy'",
],
- tags = ["no_windows"],
test_class = "com.google.devtools.build.android.desugar.runtime.ThrowableExtensionTest",
deps = [
":throwable_extension_test_utility",
@@ -50,9 +49,8 @@ java_test(
jvm_flags = [
"-Dfortest.simulated.android.sdk_int=18",
"-Dcom.google.devtools.build.android.desugar.runtime.twr_disable_mimic=true",
- "'-Dexpected.strategy=com.google.devtools.build.android.desugar.runtime.ThrowableExtension$$NullDesugaringStrategy'",
+ "-Dexpected.strategy='com.google.devtools.build.android.desugar.runtime.ThrowableExtension$$NullDesugaringStrategy'",
],
- tags = ["no_windows"],
test_class = "com.google.devtools.build.android.desugar.runtime.ThrowableExtensionTest",
deps = [
":throwable_extension_test_utility",
@@ -71,9 +69,8 @@ java_test(
srcs = ["ThrowableExtensionTest.java"],
jvm_flags = [
"-Dfortest.simulated.android.sdk_int=19",
- "'-Dexpected.strategy=com.google.devtools.build.android.desugar.runtime.ThrowableExtension$$ReuseDesugaringStrategy'",
+ "-Dexpected.strategy='com.google.devtools.build.android.desugar.runtime.ThrowableExtension$$ReuseDesugaringStrategy'",
],
- tags = ["no_windows"],
test_class = "com.google.devtools.build.android.desugar.runtime.ThrowableExtensionTest",
deps = [
":throwable_extension_test_utility",
diff --git a/src/test/java/com/google/devtools/build/android/desugar/runtime/ThrowableExtensionTestUtility.java b/src/test/java/com/google/devtools/build/android/desugar/runtime/ThrowableExtensionTestUtility.java
index b65b8bdd90..489bd7a7dc 100644
--- a/src/test/java/com/google/devtools/build/android/desugar/runtime/ThrowableExtensionTestUtility.java
+++ b/src/test/java/com/google/devtools/build/android/desugar/runtime/ThrowableExtensionTestUtility.java
@@ -27,7 +27,7 @@ public class ThrowableExtensionTestUtility {
private static final String SYSTEM_PROPERTY_EXPECTED_STRATEGY = "expected.strategy";
public static String getTwrStrategyClassNameSpecifiedInSystemProperty() {
- String className = System.getProperty(SYSTEM_PROPERTY_EXPECTED_STRATEGY);
+ String className = unquote(System.getProperty(SYSTEM_PROPERTY_EXPECTED_STRATEGY));
assertThat(className).isNotEmpty();
return className;
}
@@ -61,4 +61,13 @@ public class ThrowableExtensionTestUtility {
public static boolean isReuseStrategy() {
return isStrategyOfClass(THROWABLE_EXTENSION_CLASS_NAME + "$ReuseDesugaringStrategy");
}
+
+ private static String unquote(String s) {
+ if (s.startsWith("'") || s.startsWith("\"")) {
+ assertThat(s).endsWith(s.substring(0, 1));
+ return s.substring(1, s.length() - 1);
+ } else {
+ return s;
+ }
+ }
}