Expansion flags need some restraints.

How expanding flags interact with other possible flag qualities is not defined. Should repeated values have effects multiple times and accumulate? This doesn't really make sense, expansion flags don't have values that would accumulate. For this reason, don't allow expansion options to have allowMultiple set to true.

Likewise for other behaviors.

PiperOrigin-RevId: 167580641

1 files changed, 0 insertions, 34 deletions

diff --git a/src/test/java/com/google/devtools/common/options/OptionsParserTest.java b/src/test/java/com/google/devtools/common/options/OptionsParserTest.java
index bf8387ffc7..54bb47fa3b 100644
--- a/src/test/java/com/google/devtools/common/options/OptionsParserTest.java
+++ b/src/test/java/com/google/devtools/common/options/OptionsParserTest.java
@@ -966,40 +966,6 @@ public class OptionsParserTest {
     fail();
   }
 
-  /** ConflictingExpansionOptions */
-  public static class ConflictingExpansionsOptions extends OptionsBase {
-
-    /** ExpFunc */
-    public static class ExpFunc implements ExpansionFunction {
-      @Override
-      public ImmutableList<String> getExpansion(ExpansionContext context) {
-        return ImmutableList.of("--yyy");
-      }
-    }
-
-    @Option(
-      name = "badness",
-      expansion = {"--xxx"},
-      expansionFunction = ExpFunc.class,
-      documentationCategory = OptionDocumentationCategory.UNCATEGORIZED,
-      effectTags = {OptionEffectTag.NO_OP},
-      defaultValue = "null"
-    )
-    public Void badness;
-  }
-
-  @Test
-  public void conflictingExpansions() throws Exception {
-    try {
-      newOptionsParser(ConflictingExpansionsOptions.class);
-      fail("Should have failed due to specifying both expansion and expansionFunction");
-    } catch (AssertionError e) {
-      assertThat(e)
-          .hasMessageThat()
-          .contains("Cannot set both expansion and expansionFunction for " + "option --badness");
-    }
-  }
-
   /** NullExpansionOptions */
   public static class NullExpansionsOptions extends OptionsBase {