diff options
| author |  Kristina Chodorow <kchodorow@google.com> | 2016-09-22 17:15:15 +0000 |
|---|---|---|
| committer | Kristina Chodorow <kchodorow@google.com> | 2016-09-22 17:52:53 +0000 |
| commit | cebb7522cac6a245a491ebf7a323d8e793bb0ef1 (patch) | |
| tree | be8a95a7b70caff79c916965dccb7b883352a63b /src/test/java/com/google/devtools/build | |
| parent | 502728844b4e0e6e753dc52152580464f1fd06a1 (diff) | |
Fix Windows JDK7 tests
They're accessing non-final variables in inner classes, e.g.,:
src\test\java\com\google\devtools\build\lib\packages\BuildTypeTest.java:425: error: local variable result is accessed from within inner class; needs to be declared final
result.add(label);
(From http://ci.bazel.io/view/Bazel%20bootstrap%20and%20maintenance/job/Bazel/JAVA_VERSION=1.7,PLATFORM_NAME=windows-x86_64/845/consoleFull).
Not sure how this is working on Linux/OS X JDK7.
--
MOS_MIGRATED_REVID=133967835
Diffstat (limited to 'src/test/java/com/google/devtools/build')
| -rw-r--r-- | src/test/java/com/google/devtools/build/lib/packages/BuildTypeTest.java | 2 | ||||
| -rw-r--r-- | src/test/java/com/google/devtools/build/lib/syntax/TypeTest.java | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/packages/BuildTypeTest.java b/src/test/java/com/google/devtools/build/lib/packages/BuildTypeTest.java index e9f1c19040..6f5012fa83 100644 --- a/src/test/java/com/google/devtools/build/lib/packages/BuildTypeTest.java +++ b/src/test/java/com/google/devtools/build/lib/packages/BuildTypeTest.java @@ -417,7 +417,7 @@ public class BuildTypeTest { private static ImmutableList<Label> collectLabels(Type<?> type, Object value) throws InterruptedException { - ImmutableList.Builder<Label> result = ImmutableList.builder(); + final ImmutableList.Builder<Label> result = ImmutableList.builder(); type.visitLabels(new Type.LabelVisitor() { @SuppressWarnings("unchecked") @Override diff --git a/src/test/java/com/google/devtools/build/lib/syntax/TypeTest.java b/src/test/java/com/google/devtools/build/lib/syntax/TypeTest.java index 276c6dcdd4..a5a850e4ec 100644 --- a/src/test/java/com/google/devtools/build/lib/syntax/TypeTest.java +++ b/src/test/java/com/google/devtools/build/lib/syntax/TypeTest.java @@ -489,7 +489,7 @@ public class TypeTest { private static ImmutableList<Label> collectLabels(Type<?> type, Object value) throws InterruptedException { - ImmutableList.Builder<Label> result = ImmutableList.builder(); + final ImmutableList.Builder<Label> result = ImmutableList.builder(); type.visitLabels(new Type.LabelVisitor() { @SuppressWarnings("unchecked") @Override |