Fix LocalRepositoryLookupFunction to normalize paths so they are compared properly.

Part of #2811.

Change-Id: I15da53d1f6ec7f4a41f5d14fdd9dafd5ad82f9fc
PiperOrigin-RevId: 160982624

1 files changed, 40 insertions, 0 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/skyframe/LocalRepositoryLookupFunctionTest.java b/src/test/java/com/google/devtools/build/lib/skyframe/LocalRepositoryLookupFunctionTest.java
index c8c5bae031..12230c48d9 100644
--- a/src/test/java/com/google/devtools/build/lib/skyframe/LocalRepositoryLookupFunctionTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skyframe/LocalRepositoryLookupFunctionTest.java
@@ -164,6 +164,46 @@ public class LocalRepositoryLookupFunctionTest extends FoundationTestCase {
   }
 
   @Test
+  public void testLocalRepository_absolutePath() throws Exception {
+    scratch.overwriteFile("WORKSPACE", "local_repository(name='local', path='/abs/local/repo')");
+    scratch.file("/abs/local/repo/WORKSPACE");
+    scratch.file("/abs/local/repo/BUILD");
+
+    LocalRepositoryLookupValue repositoryLookupValue =
+        lookupDirectory(
+            RootedPath.toRootedPath(
+                rootDirectory.getRelative("/abs"), PathFragment.create("local/repo")));
+    assertThat(repositoryLookupValue).isNotNull();
+    assertThat(repositoryLookupValue.getRepository().getName()).isEqualTo("@local");
+  }
+
+  @Test
+  public void testLocalRepository_nonNormalizedPath() throws Exception {
+    scratch.overwriteFile("WORKSPACE", "local_repository(name='local', path='./local/repo')");
+    scratch.file("local/repo/WORKSPACE");
+    scratch.file("local/repo/BUILD");
+
+    LocalRepositoryLookupValue repositoryLookupValue =
+        lookupDirectory(RootedPath.toRootedPath(rootDirectory, PathFragment.create("local/repo")));
+    assertThat(repositoryLookupValue).isNotNull();
+    assertThat(repositoryLookupValue.getRepository().getName()).isEqualTo("@local");
+  }
+
+  @Test
+  public void testLocalRepository_absolutePath_nonNormalized() throws Exception {
+    scratch.overwriteFile("WORKSPACE", "local_repository(name='local', path='/abs/local/./repo')");
+    scratch.file("/abs/local/repo/WORKSPACE");
+    scratch.file("/abs/local/repo/BUILD");
+
+    LocalRepositoryLookupValue repositoryLookupValue =
+        lookupDirectory(
+            RootedPath.toRootedPath(
+                rootDirectory.getRelative("/abs"), PathFragment.create("local/repo")));
+    assertThat(repositoryLookupValue).isNotNull();
+    assertThat(repositoryLookupValue.getRepository().getName()).isEqualTo("@local");
+  }
+
+  @Test
   public void testLocalRepositorySubPackage() throws Exception {
     scratch.overwriteFile("WORKSPACE", "local_repository(name='local', path='local/repo')");
     scratch.file("local/repo/WORKSPACE");