diff options
author | tomlu <tomlu@google.com> | 2018-01-29 08:23:47 -0800 |
---|---|---|
committer | Copybara-Service <copybara-piper@google.com> | 2018-01-29 08:25:35 -0800 |
commit | 45cb2e86d18a6fbb45d3711fa7bd9f8046a15a08 (patch) | |
tree | cfd5bb16aa42b2021296b79f31d09362e1baa395 /src/test/java/com/google/devtools/build | |
parent | a35488e8ee09ca83623422f2dca3f0adc4507155 (diff) |
Do not crash when ctx.action.args.add map_fn returns a list of the wrong length.
PiperOrigin-RevId: 183668291
Diffstat (limited to 'src/test/java/com/google/devtools/build')
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java | 27 |
1 files changed, 27 insertions, 0 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java index 877bcf8786..6d78fe5e69 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java @@ -1986,6 +1986,33 @@ public class SkylarkRuleImplementationFunctionsTest extends SkylarkTestCase { } @Test + public void testLazyArgMapFnReturnsWrongArgumentCount() throws Exception { + SkylarkRuleContext ruleContext = createRuleContext("//foo:foo"); + evalRuleContextCode( + ruleContext, + "args = ruleContext.actions.args()", + "def bad_fn(args): return [0]", + "args.add([1, 2], map_fn=bad_fn)", + "ruleContext.actions.run(", + " inputs = depset(ruleContext.files.srcs),", + " outputs = ruleContext.files.srcs,", + " arguments = [args],", + " executable = ruleContext.files.tools[0],", + ")"); + SpawnAction action = + (SpawnAction) + Iterables.getOnlyElement( + ruleContext.getRuleContext().getAnalysisEnvironment().getRegisteredActions()); + try { + action.getArguments(); + fail(); + } catch (CommandLineExpansionException e) { + assertThat(e.getMessage()) + .contains("map_fn must return a list of the same length as the input"); + } + } + + @Test public void createShellWithLazyArgs() throws Exception { SkylarkRuleContext ruleContext = createRuleContext("//foo:foo"); evalRuleContextCode( |