diff options
| author |  Janak Ramakrishnan <janakr@google.com> | 2015-09-18 20:59:28 +0000 |
|---|---|---|
| committer |  Damien Martin-Guillerez <dmarting@google.com> | 2015-09-21 08:59:23 +0000 |
| commit | dad0a10d4f13a5629097e9c8dcc29dc42bb686e6 (patch) | |
| tree | 133f1a36db628201afb93c9d8a8ea1d96f0314d9 /src/test/java/com/google/devtools/build/skyframe | |
| parent | 0796d40a1c4bc84a53d5253a3f628f53fb9cdedc (diff) | |
Mark root causes as transient. Serializing nested sets is annoying, and since ErrorInfo doesn't override equality, there's no issue with preserving equality for now.
--
MOS_MIGRATED_REVID=103414237
Diffstat (limited to 'src/test/java/com/google/devtools/build/skyframe')
| -rw-r--r-- | src/test/java/com/google/devtools/build/skyframe/MemoizingEvaluatorTest.java | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/src/test/java/com/google/devtools/build/skyframe/MemoizingEvaluatorTest.java b/src/test/java/com/google/devtools/build/skyframe/MemoizingEvaluatorTest.java index 352bbb1c62..ffb5bf8b62 100644 --- a/src/test/java/com/google/devtools/build/skyframe/MemoizingEvaluatorTest.java +++ b/src/test/java/com/google/devtools/build/skyframe/MemoizingEvaluatorTest.java @@ -130,6 +130,10 @@ public class MemoizingEvaluatorTest { return true; } + protected boolean rootCausesStored() { + return true; + } + @Before public void initializeReporter() { eventCollector = new EventCollector(EventKind.ALL_EVENTS); @@ -369,7 +373,9 @@ public class MemoizingEvaluatorTest { initializeReporter(); EvaluationResult<StringValue> result = tester.eval(i == 0, "top"); assertTrue(result.hasError()); - assertThat(result.getError(topKey).getRootCauses()).containsExactly(topKey); + if (i == 0 || rootCausesStored()) { + assertThat(result.getError(topKey).getRootCauses()).containsExactly(topKey); + } assertEquals(topKey.toString(), result.getError(topKey).getException().getMessage()); assertTrue(result.getError(topKey).getException() instanceof SomeErrorException); if (i == 0 || eventsStored()) { |