diff options
author | 2016-03-03 08:08:50 +0000 | |
---|---|---|
committer | 2016-03-03 15:27:55 +0000 | |
commit | f745e99db7632cfb2145b6926f961e85f9084bc5 (patch) | |
tree | fbf6faf5c3bd701d551b0f27a2a04ab475a07ee9 /src/test/java/com/google/devtools/build/skyframe/SkyKeyTest.java | |
parent | 9b88920b70a1c0fafc5865b370d90a80ad7cae70 (diff) |
Use static creation method for SkyKey. This allows interning SkyKeys as they are created, as opposed to when they are requested from the ParallelEvaluator. That delay can lead to large memory spikes and churn.
--
MOS_MIGRATED_REVID=116224565
Diffstat (limited to 'src/test/java/com/google/devtools/build/skyframe/SkyKeyTest.java')
-rw-r--r-- | src/test/java/com/google/devtools/build/skyframe/SkyKeyTest.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test/java/com/google/devtools/build/skyframe/SkyKeyTest.java b/src/test/java/com/google/devtools/build/skyframe/SkyKeyTest.java index 8f7b247cad..0e22db30ca 100644 --- a/src/test/java/com/google/devtools/build/skyframe/SkyKeyTest.java +++ b/src/test/java/com/google/devtools/build/skyframe/SkyKeyTest.java @@ -36,7 +36,7 @@ public class SkyKeyTest { assertThat(hashCodeSpy.getNumberOfTimesHashCodeCalled()).isEqualTo(0); // When a SkyKey is constructed with that HashCodeSpy as its argument, - SkyKey originalKey = new SkyKey(SkyFunctionName.create("TEMP"), hashCodeSpy); + SkyKey originalKey = SkyKey.create(SkyFunctionName.create("TEMP"), hashCodeSpy); // Then the HashCodeSpy reports that its hashcode method was called once. assertThat(hashCodeSpy.getNumberOfTimesHashCodeCalled()).isEqualTo(1); |