Create a loadPackages() method that loads multiple packages simultaneously, using multiple threads.

The immediate upside is that if multiple packages load the same bzl file, that file will only be read once when using loadPackages().

RELNOTES: None
PiperOrigin-RevId: 156621988

1 files changed, 21 insertions, 0 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/skyframe/packages/AbstractPackageLoaderTest.java b/src/test/java/com/google/devtools/build/lib/skyframe/packages/AbstractPackageLoaderTest.java
index 40deb5089d..2d3a2bf2a6 100644
--- a/src/test/java/com/google/devtools/build/lib/skyframe/packages/AbstractPackageLoaderTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skyframe/packages/AbstractPackageLoaderTest.java
@@ -19,6 +19,8 @@ import static com.google.devtools.build.lib.testutil.MoreAsserts.assertNoEvents;
 import static org.junit.Assert.fail;
 
 import com.google.common.base.Joiner;
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableMap;
 import com.google.common.eventbus.EventBus;
 import com.google.devtools.build.lib.cmdline.PackageIdentifier;
 import com.google.devtools.build.lib.events.Reporter;
@@ -89,6 +91,25 @@ public abstract class AbstractPackageLoaderTest {
   }
 
   @Test
+  public void simpleMultipleGoodPackage() throws Exception {
+    file("good1/BUILD", "sh_library(name = 'good1')");
+    file("good2/BUILD", "sh_library(name = 'good2')");
+    PackageIdentifier pkgId1 = PackageIdentifier.createInMainRepo(PathFragment.create("good1"));
+    PackageIdentifier pkgId2 = PackageIdentifier.createInMainRepo(PathFragment.create("good2"));
+    ImmutableMap<PackageIdentifier, PackageLoader.PackageOrException> pkgs =
+        pkgLoader.loadPackages(ImmutableList.of(pkgId1, pkgId2));
+    assertThat(pkgs.get(pkgId1).get().containsErrors()).isFalse();
+    assertThat(pkgs.get(pkgId2).get().containsErrors()).isFalse();
+    assertThat(pkgs.get(pkgId1).get().getTarget("good1").getAssociatedRule().getRuleClass())
+        .isEqualTo("sh_library");
+    assertThat(pkgs.get(pkgId2).get().getTarget("good2").getAssociatedRule().getRuleClass())
+        .isEqualTo("sh_library");
+    assertNoEvents(pkgs.get(pkgId1).get().getEvents());
+    assertNoEvents(pkgs.get(pkgId2).get().getEvents());
+    assertNoEvents(handler.getEvents());
+  }
+
+  @Test
   public void simpleGoodPackage_Skylark() throws Exception {
     file("good/good.bzl",
         "def f(x):",