Have ConfiguredTargetFactory subclasses declare which FragmentOptions

they need to create their fragments.

This is prerequisite work for fragment-limited configurations
(configurations that only include the fragments needed by their rules'
 transitive closures). Given a set of desired fragment classes, we need
to know which FragmentOptions are needed to instantiate those fragments.

Note that we can't map this relationship the other way (given a set
of FragmentOptions, which fragment classes do they load?). That's
because different fragment loaders may consume overlapping options.
A good example is CppOptions, which is, e.g., used by both the C++
and Python configuration loaders.

At some point, we're probably going to want to force configuration
loaders to only understand options from their own "domain" (or have
well-defined hierarchies). But that's not the reality of today.

--
MOS_MIGRATED_REVID=94091093

1 files changed, 6 insertions, 0 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/analysis/config/BuildConfigurationTest.java b/src/test/java/com/google/devtools/build/lib/analysis/config/BuildConfigurationTest.java
index 46c7009b51..63a64b0d74 100644
--- a/src/test/java/com/google/devtools/build/lib/analysis/config/BuildConfigurationTest.java
+++ b/src/test/java/com/google/devtools/build/lib/analysis/config/BuildConfigurationTest.java
@@ -15,6 +15,7 @@ package com.google.devtools.build.lib.analysis.config;
 
 import static com.google.common.truth.Truth.assertThat;
 
+import com.google.common.collect.ImmutableSet;
 import com.google.devtools.build.lib.analysis.config.BuildConfiguration.Fragment;
 import com.google.devtools.build.lib.analysis.util.ConfigurationTestCase;
 import com.google.devtools.build.lib.packages.Attribute.ConfigurationTransition;
@@ -200,6 +201,11 @@ public class BuildConfigurationTest extends ConfigurationTestCase {
       }
 
       @Override
+      public ImmutableSet<Class<? extends FragmentOptions>> requiredOptions() {
+        return ImmutableSet.of();
+      }
+
+      @Override
       public Fragment create(ConfigurationEnvironment env, BuildOptions buildOptions)
           throws InvalidConfigurationException {
         for (Class<? extends Fragment> fragmentType : dependsOn) {