diff options
author | Florian Weikert <fwe@google.com> | 2015-12-04 15:48:25 +0000 |
---|---|---|
committer | Kristina Chodorow <kchodorow@google.com> | 2015-12-04 21:06:48 +0000 |
commit | df4194f47f2e1777301071b48dedf9a80b2264b8 (patch) | |
tree | 6bdc52bc5d80dafcf995707b47a283935ab4518a /src/test/java/com/google/devtools/build/lib/testutil | |
parent | bcacf3fdc3e5ed8c1283123376bff9ac26c49226 (diff) |
TestSuiteBuilder should include TautologyTest only in empty test suites.
Previously, TautologyTest was added to all test suites in order to prevent empty one. However, this was done regardless of whether the suite was actually empty or not.
--
MOS_MIGRATED_REVID=109413743
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/testutil')
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/testutil/TestSuiteBuilder.java | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/testutil/TestSuiteBuilder.java b/src/test/java/com/google/devtools/build/lib/testutil/TestSuiteBuilder.java index 00be92b4e2..f6588cbdb0 100644 --- a/src/test/java/com/google/devtools/build/lib/testutil/TestSuiteBuilder.java +++ b/src/test/java/com/google/devtools/build/lib/testutil/TestSuiteBuilder.java @@ -81,12 +81,14 @@ public final class TestSuiteBuilder { */ public Set<Class<?>> create() { Set<Class<?>> result = new LinkedHashSet<>(); - // We have some cases where the resulting test suite is empty, which some of our test - // infrastructure treats as an error. - result.add(TautologyTest.class); for (Class<?> testClass : Iterables.filter(testClasses, matchClassPredicate)) { result.add(testClass); } + if (result.isEmpty()) { + // We have some cases where the resulting test suite is empty, which some of our test + // infrastructure treats as an error. + result.add(TautologyTest.class); + } return result; } |