Improve error message for select objects ('+' operator for incompatible types)

--
MOS_MIGRATED_REVID=107131704

1 files changed, 16 insertions, 0 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/syntax/EvaluationTest.java b/src/test/java/com/google/devtools/build/lib/syntax/EvaluationTest.java
index 5a578e8e27..be1cf6d0db 100644
--- a/src/test/java/com/google/devtools/build/lib/syntax/EvaluationTest.java
+++ b/src/test/java/com/google/devtools/build/lib/syntax/EvaluationTest.java
@@ -530,6 +530,22 @@ public class EvaluationTest extends EvaluationTestCase {
   }
 
   @Test
+  public void testAddSelectIncompatibleType() throws Exception {
+    newTest()
+        .testIfErrorContains(
+            "'+' operator applied to incompatible types (select of list, int)",
+            "select({'foo': ['FOO'], 'bar': ['BAR']}) + 1");
+  }
+
+  @Test
+  public void testAddSelectIncompatibleType2() throws Exception {
+    newTest()
+        .testIfErrorContains(
+            "'+' operator applied to incompatible types (select of list, select of int)",
+            "select({'foo': ['FOO']}) + select({'bar': 2})");
+  }
+
+  @Test
   public void testListComprehensionFailsOnNonSequence() throws Exception {
     newTest().testIfErrorContains("type 'int' is not iterable", "[x + 1 for x in 123]");
   }