Fix the definition of Argument in the Skylark specification

PiperOrigin-RevId: 191717115

1 files changed, 10 insertions, 0 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/syntax/BaseFunctionTest.java b/src/test/java/com/google/devtools/build/lib/syntax/BaseFunctionTest.java
index 575b03f662..8933ce6a05 100644
--- a/src/test/java/com/google/devtools/build/lib/syntax/BaseFunctionTest.java
+++ b/src/test/java/com/google/devtools/build/lib/syntax/BaseFunctionTest.java
@@ -157,4 +157,14 @@ public class BaseFunctionTest extends EvaluationTestCase {
         .isEqualTo("{\"name\": \"foo\", \"type\": \"jpg\", \"version\": 42}");
     assertThat(Printer.repr(lookup("b2"))).isEqualTo("{}");
   }
+
+  @Test
+  public void testCommaAfterArgsAndKwargs() throws Exception {
+    // Test that commas are not allowed in function definitions and calls
+    // after last *args or **kwargs expressions.
+    checkEvalErrorContains("syntax error at ')': expected identifier", "def foo(*args,): pass");
+    checkEvalErrorContains("unexpected tokens after kwarg", "def foo(**kwargs,): pass");
+    checkEvalErrorContains("syntax error at ')': expected expression", "foo(*args,)");
+    checkEvalErrorContains("unexpected tokens after kwarg", "foo(**kwargs,)");
+  }
 }