aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
diff options
context:
space:
mode:
authorGravatar dslomov <dslomov@google.com>2017-04-11 12:18:09 +0000
committerGravatar Jakob Buchgraber <buchgr@google.com>2017-04-12 11:48:55 +0200
commit423dccc87c4651d3d188f83dca5ce9362dad180e (patch)
tree40f27696a3dbc16e2299469392fb45c73a5ad6f0 /src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
parentc83c570ccf619a0afb9919851067a825eb1ac9ff (diff)
Make immutability explicit for things exposed to Skylark.
RELNOTES: None. PiperOrigin-RevId: 152800780
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java')
-rw-r--r--src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java b/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
index 32932b6a73..848498b229 100644
--- a/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
+++ b/src/test/java/com/google/devtools/build/lib/syntax/SkylarkEvaluationTest.java
@@ -26,12 +26,14 @@ import com.google.devtools.build.lib.analysis.FileConfiguredTarget;
import com.google.devtools.build.lib.analysis.RuleConfiguredTarget;
import com.google.devtools.build.lib.analysis.TransitiveInfoCollection;
import com.google.devtools.build.lib.collect.nestedset.NestedSetBuilder;
+import com.google.devtools.build.lib.concurrent.ThreadSafety.Immutable;
import com.google.devtools.build.lib.packages.NativeClassObjectConstructor;
import com.google.devtools.build.lib.packages.SkylarkClassObject;
import com.google.devtools.build.lib.skylarkinterface.Param;
import com.google.devtools.build.lib.skylarkinterface.SkylarkCallable;
import com.google.devtools.build.lib.skylarkinterface.SkylarkModule;
import com.google.devtools.build.lib.skylarkinterface.SkylarkSignature;
+import com.google.devtools.build.lib.skylarkinterface.SkylarkValue;
import com.google.devtools.build.lib.syntax.SkylarkList.MutableList;
import com.google.devtools.build.lib.testutil.TestMode;
import org.junit.Before;
@@ -59,6 +61,7 @@ public class SkylarkEvaluationTest extends EvaluationTest {
return new SkylarkTest();
}
+ @Immutable
static class Bad {
Bad () {
}
@@ -100,11 +103,11 @@ public class SkylarkEvaluationTest extends EvaluationTest {
}
@SuppressWarnings("unused")
@SkylarkCallable(name = "nullfunc_failing", doc = "", allowReturnNones = false)
- public Object nullfuncFailing(String p1, Integer p2) {
+ public SkylarkValue nullfuncFailing(String p1, Integer p2) {
return null;
}
@SkylarkCallable(name = "nullfunc_working", doc = "", allowReturnNones = true)
- public Object nullfuncWorking() {
+ public SkylarkValue nullfuncWorking() {
return null;
}
@SkylarkCallable(name = "voidfunc", doc = "")