aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/test/java/com/google/devtools/build/lib/syntax/ParserTest.java
diff options
context:
space:
mode:
authorGravatar brandjon <brandjon@google.com>2017-07-06 08:54:29 -0400
committerGravatar John Cater <jcater@google.com>2017-07-07 07:06:32 -0400
commit09771fd28b3f2744b264ef0208c3c96500692bdf (patch)
tree943075eec2a2095f74ed8346d2b651898e90e76c /src/test/java/com/google/devtools/build/lib/syntax/ParserTest.java
parent4ca8b8f98f043ef624b2d1605d658aa39c2c63dc (diff)
Prohibit multiple load() statements from appearing on the same line
This is an incompatible change, but it's an obvious bug. RELNOTES[INC]: Fixed a bug whereby multiple load() statements could appear on the same line PiperOrigin-RevId: 161070399
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/syntax/ParserTest.java')
-rw-r--r--src/test/java/com/google/devtools/build/lib/syntax/ParserTest.java13
1 files changed, 10 insertions, 3 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/syntax/ParserTest.java b/src/test/java/com/google/devtools/build/lib/syntax/ParserTest.java
index 62e176eae7..f0cd551b14 100644
--- a/src/test/java/com/google/devtools/build/lib/syntax/ParserTest.java
+++ b/src/test/java/com/google/devtools/build/lib/syntax/ParserTest.java
@@ -1219,16 +1219,23 @@ public class ParserTest extends EvaluationTestCase {
}
@Test
- public void testLoadSyntaxError() throws Exception {
+ public void testLoadLabelQuoteError() throws Exception {
setFailFast(false);
parseFileForSkylark("load(non_quoted, 'a')\n");
assertContainsError("syntax error");
}
@Test
- public void testLoadSyntaxError2() throws Exception {
+ public void testLoadSymbolQuoteError() throws Exception {
setFailFast(false);
- parseFileForSkylark("load('non_quoted', a)\n");
+ parseFileForSkylark("load('label', non_quoted)\n");
+ assertContainsError("syntax error");
+ }
+
+ @Test
+ public void testLoadDisallowSameLine() throws Exception {
+ setFailFast(false);
+ parseFileForSkylark("load('foo.bzl', 'foo') load('bar.bzl', 'bar')");
assertContainsError("syntax error");
}