aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/test/java/com/google/devtools/build/lib/skylark
diff options
context:
space:
mode:
authorGravatar dslomov <dslomov@google.com>2017-06-30 10:07:48 +0200
committerGravatar Marcel Hlopko <hlopko@google.com>2017-06-30 13:01:52 +0200
commitae0b7742e19a5cf4f650d71d9c4b26a4ab2908bf (patch)
treed85f5d8bdd4f2e20b968041f3ad8b6ee987cba19 /src/test/java/com/google/devtools/build/lib/skylark
parentd9c2ab94a9a8e76c8b5268e7dbda52c893984541 (diff)
Implement ctx.actions.do_nothing instead of ctx.empty_action
RELNOTES: None. PiperOrigin-RevId: 160621674
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/skylark')
-rw-r--r--src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleContextTest.java1
-rw-r--r--src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java8
2 files changed, 5 insertions, 4 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleContextTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleContextTest.java
index 3333e6ba81..202bc66833 100644
--- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleContextTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleContextTest.java
@@ -1861,6 +1861,7 @@ public class SkylarkRuleContextTest extends SkylarkTestCase {
"actions.declare_file('foo.txt', sibling = file)",
"actions.declare_directory('foo.txt')",
"actions.declare_directory('foo.txt', sibling = file)",
+ "actions.do_nothing(mnemonic = 'foo', inputs = [file])",
"check_placeholders('foo', [])",
"action(command = 'foo', outputs = [file])",
"file_action(file, 'foo')",
diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java
index 21f6e08142..9677078bf6 100644
--- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java
@@ -433,14 +433,14 @@ public class SkylarkRuleImplementationFunctionsTest extends SkylarkTestCase {
checkErrorContains(
ruleContext,
- "missing mandatory named-only argument 'mnemonic' while calling empty_action",
- "ruleContext.empty_action(inputs = ruleContext.files.srcs)");
+ "parameter 'mnemonic' has no default value, in method do_nothing(list inputs) of 'actions'",
+ "ruleContext.actions.do_nothing(inputs = ruleContext.files.srcs)");
}
private void checkEmptyAction(SkylarkRuleContext ruleContext, String namedArgs) throws Exception {
assertThat(
evalRuleContextCode(
- ruleContext, String.format("ruleContext.empty_action(%s)", namedArgs)))
+ ruleContext, String.format("ruleContext.actions.do_nothing(%s)", namedArgs)))
.isEqualTo(Runtime.NONE);
}
@@ -449,7 +449,7 @@ public class SkylarkRuleImplementationFunctionsTest extends SkylarkTestCase {
scratch.file(
"test/empty.bzl",
"def _impl(ctx):",
- " ctx.empty_action(",
+ " ctx.actions.do_nothing(",
" inputs = ctx.files.srcs,",
" mnemonic = 'EA',",
" )",