diff options
| author |  Han-Wen Nienhuys <hanwen@google.com> | 2016-01-21 17:00:47 +0000 |
|---|---|---|
| committer |  Damien Martin-Guillerez <dmarting@google.com> | 2016-01-21 19:10:12 +0000 |
| commit | 612d22190c9bdfd8288f7685dc8d89da07443d51 (patch) | |
| tree | 14305ebff67cba7d93e018056be71b3435c9ffce /src/test/java/com/google/devtools/build/lib/skylark | |
| parent | 791265874faf26f63093dbcd4476fda9f10e1f32 (diff) | |
Raise error if we find an unknown type in native.rule().
Handle more types:
* Boolean
* TriState
* SkylarkValue (eg. FileSetEntry)
* skip Licenses, Distribs.
--
MOS_MIGRATED_REVID=112690550
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/skylark')
| -rw-r--r-- | src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleContextTest.java | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleContextTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleContextTest.java index 4ed30baf18..088a542c89 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleContextTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleContextTest.java @@ -370,7 +370,10 @@ public class SkylarkRuleContextTest extends SkylarkTestCase { scratch.file( "test/getrule/BUILD", "load('/test/skylark/rulestr', 'rules_dict', 'rule_dict', 'nop_rule', 'consume_rule')", - "genrule(name = 'a', outs = ['a.txt'], tools = [ '//test:bla' ], cmd = 'touch $@')", + "genrule(name = 'a', outs = ['a.txt'], ", + " licenses = ['notice'],", + " output_to_bindir = False,", + " tools = [ '//test:bla' ], cmd = 'touch $@')", "nop_rule(name = 'c', x = ':a')", "rlist= rules_dict()", "consume_rule(name = 'all_str', s = [rlist['a']['kind'], rlist['a']['name'], ", @@ -406,16 +409,21 @@ public class SkylarkRuleContextTest extends SkylarkTestCase { ImmutableList.<String>of( "cmd", "compatible_with", + "executable", "features", "generator_function", "generator_location", "generator_name", + "heuristic_label_expansion", "kind", + "local", "message", "name", + "output_to_bindir", "outs", "restricted_to", "srcs", + "stamp", "tags", "tools", "visibility")), |