diff options
| author |  jcater <jcater@google.com> | 2018-06-19 14:14:34 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-06-19 14:15:59 -0700 |
| commit | 5f292bb18e98172a3540c92bfa7d38eba1cac624 (patch) | |
| tree | 044ed085ca19968b8ad12b635863d863956b939c /src/test/java/com/google/devtools/build/lib/skylark | |
| parent | e032e31abefe9643ded6686a30458429690a4cf5 (diff) | |
Be more permissive when dealing with rules which have
ExecutionPlatformConstraintsAllowed set to PER_TARGET and also have an
alread-existing exec_compatible_with attribute.
PiperOrigin-RevId: 201238805
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/skylark')
| -rw-r--r-- | src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java | 18 |
1 files changed, 0 insertions, 18 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java index 5a68334bba..23d9142131 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleClassFunctionsTest.java @@ -1655,24 +1655,6 @@ public class SkylarkRuleClassFunctionsTest extends SkylarkTestCase { } @Test - public void testTargetsCanAddExecutionPlatformConstraints_attrAlreadyDefined() throws Exception { - registerDummyUserDefinedFunction(); - scratch.file("test/BUILD", "toolchain_type(name = 'my_toolchain_type')"); - ev.setFailFast(false); - evalAndExport( - "r1 = rule(impl, ", - " attrs = {", - " 'exec_compatible_with': attr.label_list(),", - " },", - " toolchains=['//test:my_toolchain_type'],", - " execution_platform_constraints_allowed=True,", - ")"); - ev.assertContainsError( - "Rule //fake/label.bzl:label.bzl%r1 should not already" - + " define the attribute \"exec_compatible_with\""); - } - - @Test public void testRuleFunctionReturnsNone() throws Exception { scratch.file("test/rule.bzl", "def _impl(ctx):", |