aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/test/java/com/google/devtools/build/lib/skylark
diff options
context:
space:
mode:
authorGravatar Googler <noreply@google.com>2017-04-09 17:58:18 -0400
committerGravatar Kristina Chodorow <kchodorow@google.com>2017-05-09 10:54:03 -0400
commit4e0a5cb6209952ff9d83b9aa41d68c133ea4a964 (patch)
treea230735a364d1d7e68755b30cd2dc76330ef35ce /src/test/java/com/google/devtools/build/lib/skylark
parent6daff173a68287452598f735f5bae2134fae0815 (diff)
Optimize TransitiveInfoMap memory consumption.
Instead of using ImmutableMap, we share the keys between all provider maps with an identical key set. PiperOrigin-RevId: 155432135
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/skylark')
-rw-r--r--src/test/java/com/google/devtools/build/lib/skylark/SkylarkAspectsTest.java15
1 files changed, 12 insertions, 3 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkAspectsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkAspectsTest.java
index 2ecdf0864d..6a8d28b7c6 100644
--- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkAspectsTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkAspectsTest.java
@@ -813,7 +813,12 @@ public class SkylarkAspectsTest extends AnalysisTestCase {
AnalysisResult result = update(ImmutableList.of("test/aspect.bzl%MyAspect"), "//test:zzz.jar");
assertThat(result.hasError()).isFalse();
- assertThat(Iterables.getOnlyElement(result.getAspects()).getConfiguredAspect()).isEmpty();
+ assertThat(
+ Iterables.getOnlyElement(result.getAspects())
+ .getConfiguredAspect()
+ .getProviders()
+ .getProviderCount())
+ .isEqualTo(0);
}
@@ -1714,8 +1719,12 @@ public class SkylarkAspectsTest extends AnalysisTestCase {
AnalysisResult analysisResult =
update(ImmutableList.of("test/aspect.bzl%MyAspect"), "//test:file.txt");
assertThat(analysisResult.hasError()).isFalse();
- assertThat(Iterables.getOnlyElement(analysisResult.getAspects()).getConfiguredAspect())
- .isEmpty();
+ assertThat(
+ Iterables.getOnlyElement(analysisResult.getAspects())
+ .getConfiguredAspect()
+ .getProviders()
+ .getProviderCount())
+ .isEqualTo(0);
}
@Test