Clean up string representations for functions

If --incompatible_descriptive_string_representations is passed, functions and rule
classes are converted to strings using `str`, `repr` and `print` functions
differently (more descriptive, without leaking information that shouldn't
be accessible).

PiperOrigin-RevId: 161087777

1 files changed, 23 insertions, 0 deletions

diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkStringRepresentationsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkStringRepresentationsTest.java
index 7c777e28f5..d503ec9803 100644
--- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkStringRepresentationsTest.java
+++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkStringRepresentationsTest.java
@@ -214,6 +214,23 @@ public class SkylarkStringRepresentationsTest extends SkylarkTestCase {
     assertStringRepresentation("struct(d = 4, c = 3)", "struct(c = 3, d = 4)");
   }
 
+
+  @Test
+  public void testStringRepresentations_Functions() throws Exception {
+    setSkylarkSemanticsOptions("--incompatible_descriptive_string_representations=true");
+
+    assertStringRepresentation("all", "<built-in function all>");
+    assertStringRepresentation("def f(): pass", "f", "<function f from //eval:eval.bzl>");
+  }
+
+  @Test
+  public void testStringRepresentations_Rules() throws Exception {
+    setSkylarkSemanticsOptions("--incompatible_descriptive_string_representations=true");
+
+    assertStringRepresentation("native.cc_library", "<built-in rule cc_library>");
+    assertStringRepresentation("rule(implementation=str)", "<rule>");
+  }
+
   @Test
   public void testLegacyStringRepresentations_Labels() throws Exception {
     setSkylarkSemanticsOptions("--incompatible_descriptive_string_representations=false");
@@ -246,6 +263,12 @@ public class SkylarkStringRepresentationsTest extends SkylarkTestCase {
 
     assertStringRepresentation("native.cc_library", "<function cc_library>");
     assertStringRepresentation("rule(implementation=str)", "<function rule>");
+  }
+
+  @Test
+  public void testLegacyStringRepresentations_Aspects() throws Exception {
+    setSkylarkSemanticsOptions("--incompatible_descriptive_string_representations=false");
+
     assertStringRepresentation("aspect(implementation=str)", "Aspect:<function str>");
   }