diff options
author | tomlu <tomlu@google.com> | 2017-11-06 19:49:16 +0100 |
---|---|---|
committer | Damien Martin-Guillerez <dmarting@google.com> | 2017-11-06 20:20:32 +0100 |
commit | 67c84b1036ad02ba2384fa75fb28e779a488f3d4 (patch) | |
tree | c70665241fab2a4947f0941659b8e6421eabb44c /src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java | |
parent | 11517396816697ad1c48a71e47f37d9206225741 (diff) |
Break dependency on vfs from the interface of syntax and cmdline.
These libs are exposed externally, implying that the vfs is also exposed externally.
We break out PathFragment from vfs to still use this in their interface. This class is a much smaller dependency than the entire vfs.
PiperOrigin-RevId: 174729373
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java')
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java index bb588ecfe4..07079d9d09 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java @@ -670,9 +670,10 @@ public class SkylarkRuleImplementationFunctionsTest extends SkylarkTestCase { * usually write those files using UTF-8 encoding. Currently, the string-valued 'substitutions' * parameter of the template_action function contains a hack that assumes its input is a UTF-8 * encoded string which has been ingested as Latin 1. The hack converts the string to its - * "correct" UTF-8 value. Once {@link com.google.devtools.build.lib.syntax.ParserInputSource#create(com.google.devtools.build.lib.vfs.Path)} - * parses files using UTF-8 and the hack for the substituations parameter is removed, this test - * will fail. + * "correct" UTF-8 value. Once {@link + * com.google.devtools.build.lib.syntax.ParserInputSource#create(byte[], + * com.google.devtools.build.lib.vfs.PathFragment)} parses files using UTF-8 and the hack for the + * substituations parameter is removed, this test will fail. */ @Test public void testCreateTemplateActionWithWrongEncoding() throws Exception { |