diff options
| author |  tomlu <tomlu@google.com> | 2018-07-25 10:16:52 -0700 |
|---|---|---|
| committer |  Copybara-Service <copybara-piper@google.com> | 2018-07-25 10:18:11 -0700 |
| commit | 61f477e8193b83864824f30b06b9e1576d06f4d5 (patch) | |
| tree | 5d218fdd138fda70eb2248590980f0232654cd7f /src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java | |
| parent | 80b4b95175ffda4d4ec11366e5a606c010509792 (diff) | |
Use the single-string arg formatter for param file format.
This avoids bazel crashes for illegally formatted strings. Previously the code would assume that a correct string was passed with only minimal validation.
RELNOTES: None
PiperOrigin-RevId: 206012819
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java')
| -rw-r--r-- | src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java index e55829d038..d3568b2017 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java +++ b/src/test/java/com/google/devtools/build/lib/skylark/SkylarkRuleImplementationFunctionsTest.java @@ -2379,6 +2379,10 @@ public class SkylarkRuleImplementationFunctionsTest extends SkylarkTestCase { ruleContext, "Invalid value for parameter \"param_file_arg\": Expected string with a single \"%s\"", "args = ruleContext.actions.args()\n" + "args.use_param_file('--file=')"); + checkError( + ruleContext, + "Invalid value for parameter \"param_file_arg\": Expected string with a single \"%s\"", + "args = ruleContext.actions.args()\n" + "args.use_param_file('--file=%s%s')"); } @Test |