diff options
author | gregce <gregce@google.com> | 2017-07-27 22:09:34 +0200 |
---|---|---|
committer | Jakob Buchgraber <buchgr@google.com> | 2017-07-28 10:44:52 +0200 |
commit | da4c959603280ded71ad8fbc2d30d4917b175750 (patch) | |
tree | dd201d03665350c1fec5247eba18af0bea4dd205 /src/test/java/com/google/devtools/build/lib/skyframe/ConfigurationsForTargetsWithDynamicConfigurationsTest.java | |
parent | d8235cf959ac1326836064aa9442256b69f7318a (diff) |
Fix confusing semantics for Attribute.Builder.allowedRuleClasses.
1) Update the javadocs.
2) Clarify that allowedRuleClases and allowedRuleClassesWithWarning
must be disjoint sets.
3) Enforce 2).
4) Fix error messaging when only "with warnings" is set.
PiperOrigin-RevId: 163379567
Diffstat (limited to 'src/test/java/com/google/devtools/build/lib/skyframe/ConfigurationsForTargetsWithDynamicConfigurationsTest.java')
-rw-r--r-- | src/test/java/com/google/devtools/build/lib/skyframe/ConfigurationsForTargetsWithDynamicConfigurationsTest.java | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/test/java/com/google/devtools/build/lib/skyframe/ConfigurationsForTargetsWithDynamicConfigurationsTest.java b/src/test/java/com/google/devtools/build/lib/skyframe/ConfigurationsForTargetsWithDynamicConfigurationsTest.java index b30124244a..ba5a07cb3c 100644 --- a/src/test/java/com/google/devtools/build/lib/skyframe/ConfigurationsForTargetsWithDynamicConfigurationsTest.java +++ b/src/test/java/com/google/devtools/build/lib/skyframe/ConfigurationsForTargetsWithDynamicConfigurationsTest.java @@ -431,7 +431,7 @@ public class ConfigurationsForTargetsWithDynamicConfigurationsTest private static final class RuleWithOutgoingTransition implements MockRule { @Override public State define() { - return MockRule.define("change_deps"); + return MockRule.define("change_deps", MockRule.DEPS_ATTRIBUTE); } @Override |